From: Andreas Schultz <aschultz@tpip.net>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: netdev <netdev@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
laforge <laforge@gnumonks.org>,
Johannes Berg <johannes.berg@intel.com>,
pablo <pablo@netfilter.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/5] GTP: Fine-tuning for some function implementations
Date: Thu, 26 Jan 2017 12:14:07 +0100 (CET) [thread overview]
Message-ID: <1065111512.617676.1485429247267.JavaMail.zimbra@tpip.net> (raw)
In-Reply-To: <698070a4-e08e-78e5-0214-df69783cce22@users.sourceforge.net>
Hi Markus,
----- On Jan 26, 2017, at 11:15 AM, SF Markus Elfring elfring@users.sourceforge.net wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 26 Jan 2017 11:10:01 +0100
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
> Use kmalloc_array() in gtp_hashtable_new()
> Improve another size determination in ipv4_pdp_add()
> Adjust 12 checks for null pointers
> Rename jump labels in gtp_encap_enable()
> Rename jump labels in gtp_hashtable_new()
Looks good to me, for all the above:
Reviewed-by: Andreas Schultz <aschultz@tpip.net>
Andreas
>
> drivers/net/gtp.c | 46 ++++++++++++++++++++++++----------------------
> 1 file changed, 24 insertions(+), 22 deletions(-)
>
> --
> 2.11.0
prev parent reply other threads:[~2017-01-26 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 10:15 SF Markus Elfring
2017-01-26 10:17 ` [PATCH 1/5] gtp: Use kmalloc_array() in gtp_hashtable_new() SF Markus Elfring
2017-01-26 10:18 ` [PATCH 2/5] gtp: Improve another size determination in ipv4_pdp_add() SF Markus Elfring
2017-01-26 13:11 ` Alexey Dobriyan
2017-01-26 10:19 ` [PATCH 3/5] gtp: Adjust 12 checks for null pointers SF Markus Elfring
2017-01-26 10:20 ` [PATCH 4/5] gtp: Rename jump labels in gtp_encap_enable() SF Markus Elfring
2017-01-26 10:22 ` [PATCH 5/5] gtp: Rename jump labels in gtp_hashtable_new() SF Markus Elfring
2017-01-26 11:14 ` Andreas Schultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1065111512.617676.1485429247267.JavaMail.zimbra@tpip.net \
--to=aschultz@tpip.net \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome