From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1362EB64DD for ; Thu, 3 Aug 2023 04:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbjHCEGe (ORCPT ); Thu, 3 Aug 2023 00:06:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231577AbjHCEGP (ORCPT ); Thu, 3 Aug 2023 00:06:15 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4D07E2D69 for ; Wed, 2 Aug 2023 21:06:13 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96D94113E; Wed, 2 Aug 2023 21:06:55 -0700 (PDT) Received: from [10.162.42.10] (unknown [10.162.42.10]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC13E3F5A1; Wed, 2 Aug 2023 21:06:10 -0700 (PDT) Message-ID: <106602d4-fff5-be88-a265-847e9edf8097@arm.com> Date: Thu, 3 Aug 2023 09:36:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V2 2/4] arm_pmu: acpi: Add a representative platform device for TRBE Content-Language: en-US To: Suzuki K Poulose , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Mark Rutland , linux-kernel@vger.kernel.org References: <20230801094052.750416-1-anshuman.khandual@arm.com> <20230801094052.750416-3-anshuman.khandual@arm.com> <20230801145111.GF26253@willie-the-truck> <505c6b25-d9e8-d7b3-1a0d-2b51e45fb66a@arm.com> <2c1894c4-c0e3-ea90-d5f6-24c3ed8c0e4f@arm.com> From: Anshuman Khandual In-Reply-To: <2c1894c4-c0e3-ea90-d5f6-24c3ed8c0e4f@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/23 15:41, Suzuki K Poulose wrote: > On 02/08/2023 02:07, Anshuman Khandual wrote: >> >> >> On 8/1/23 20:21, Will Deacon wrote: >>> On Tue, Aug 01, 2023 at 03:10:50PM +0530, Anshuman Khandual wrote: >>>> diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h >>>> index a0801f68762b..7ec26d21303d 100644 >>>> --- a/include/linux/perf/arm_pmu.h >>>> +++ b/include/linux/perf/arm_pmu.h >>>> @@ -187,5 +187,6 @@ void armpmu_free_irq(int irq, int cpu); >>>>   #endif /* CONFIG_ARM_PMU */ >>>>     #define ARMV8_SPE_PDEV_NAME "arm,spe-v1" >>>> +#define ARMV8_TRBE_PDEV_NAME "arm-trbe-acpi" >>> >>> Why is the TRBE name formatted differently to the SPE one? >> >> Nothing specific, although "arm,spe-v1" seemed more like a DT naming >> scheme. But could change the name as "arm,trbe-v1" to be in sync with >> SPE here. > > Do we really need v1 ? I would leave it as arm,trbe Sure, will make it 'arm,trbe' instead.