From: James Bottomley <James.Bottomley@steeleye.com>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: jamesclv@us.ibm.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Fix x86 subarch breakage by the patch to allow more APIC irq sources
Date: 22 Oct 2003 10:56:31 -0500 [thread overview]
Message-ID: <1066838206.1781.66.camel@mulgrave> (raw)
The problem with this patch was that it defined a new quantity
NR_IRQ_VECTORS. However, the definition of NR_IRQ_VECTORS is only in
mach-default/irq_vectors.h. Every subarch which defines it's own
irq_vectors.h (that's voyager, visws and pc9800) now won't compile.
I think the best fix is the attached (although you could clean up
mach-default/irq_vectors.h with this too).
James
===== include/asm-i386/irq.h 1.9 vs edited =====
--- 1.9/include/asm-i386/irq.h Wed Apr 23 02:49:34 2003
+++ edited/include/asm-i386/irq.h Wed Oct 22 10:49:21 2003
@@ -15,6 +15,10 @@
/* include comes from machine specific directory */
#include "irq_vectors.h"
+#ifndef NR_IRQ_VECTORS
+#define NR_IRQ_VECTORS NR_IRQS
+#endif
+
static __inline__ int irq_canonicalize(int irq)
{
return ((irq == 2) ? 9 : irq);
next reply other threads:[~2003-10-22 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-22 15:56 James Bottomley [this message]
2003-10-22 16:31 ` Linus Torvalds
2003-10-22 16:59 ` James Bottomley
2003-10-23 3:41 ` James Cleverdon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1066838206.1781.66.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=jamesclv@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome