mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Tzung-Bi Shih <tzungbi@google.com>,
	bleung@chromium.org, groeck@chromium.org, rrangel@chromium.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jimmy Cheng-Yi Chiang <cychiang@google.com>,
	Dylan Reid <dgreid@google.com>
Subject: Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating script
Date: Thu, 1 Aug 2019 12:59:23 +0200	[thread overview]
Message-ID: <106711f8-117a-d0df-9b66-dc6be6431d07@collabora.com> (raw)
In-Reply-To: <CA+Px+wXetT1mQZW+3zc2vNDP4Jf3zKqGNz=Hq0yHn0Fvf=y-FQ@mail.gmail.com>

Hi Tzung-Bi

On 30/7/19 16:07, Tzung-Bi Shih wrote:
> Hi Enric,
> 
> I found it is error-prone to replace the EC_CMDS after updated.
> Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".

I am not sure I get you here, a .inc? could you explain a bit more?

Thanks,
~ Enric

> The generating script replaces whole ".inc" file every time and the
> cros_ec_trace.c includes the "cros_ec_trace.inc".
> 
> If this proposal makes sense to you, I can send the patch after this
> change landed for*-next.
> 

  reply	other threads:[~2019-08-01 10:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 13:47 Tzung-Bi Shih
2019-07-30 14:07 ` Tzung-Bi Shih
2019-08-01 10:59   ` Enric Balletbo i Serra [this message]
2019-08-01 13:04     ` Tzung-Bi Shih
2019-08-01 13:30       ` Enric Balletbo i Serra
2019-08-01 14:50         ` Raul Rangel
     [not found]           ` <CA+Px+wUzyFB6vRM91PTFkY_fBfp2xybegy34rbW_D9zzNX6-8Q@mail.gmail.com>
2019-08-29 13:42             ` Enric Balletbo i Serra
2019-08-29 13:51               ` Enric Balletbo Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=106711f8-117a-d0df-9b66-dc6be6431d07@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=cychiang@google.com \
    --cc=dgreid@google.com \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rrangel@chromium.org \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®