From: David Howells <dhowells@redhat.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Checkpatch errors that should be downgraded
Date: Thu, 02 Feb 2023 11:16:13 +0000 [thread overview]
Message-ID: <1068166.1675336573@warthog.procyon.org.uk> (raw)
In the trace headers, the following should probably be ignored:
CHECK: Lines should not end with a '('
#73: FILE: include/trace/events/rxrpc.h:1947:
+ TP_STRUCT__entry(
CHECK: Lines should not end with a '('
#80: FILE: include/trace/events/rxrpc.h:1954:
+ TP_fast_assign(
as it's standard practice to bump the contents onto the next line for these
two macros.
Also checkpatch is wrong in giving this error:
ERROR: Macros with complex values should be enclosed in parentheses
#37: FILE: include/trace/events/rxrpc.h:425:
+#define rxrpc_sack_traces \
+ EM(rxrpc_sack_advance, "ADV") \
+ EM(rxrpc_sack_fill, "FIL") \
+ EM(rxrpc_sack_nack, "NAK") \
+ EM(rxrpc_sack_none, "---") \
+ E_(rxrpc_sack_oos, "OOS")
as the contents, when found in a trace header, are going to be used to
generate a string table and maybe an enum. It's standard practice, so if it
could be ignored in trace headers or at least downgraded to a warning?
Thanks,
David
next reply other threads:[~2023-02-02 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 11:16 David Howells [this message]
2023-02-02 17:03 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1068166.1675336573@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®