mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: Bernhard Kaindl <bernhard.kaindl@gmx.de>
Cc: "Erik A. Hendriks" <hendriks@lanl.gov>, linux-kernel@vger.kernel.org
Subject: Re: ptrace + ioctl( LOOP_SET_FD ) brokeness.
Date: Fri, 14 Nov 2003 14:29:18 +0100	[thread overview]
Message-ID: <1068816558.5206.0.camel@laptop.fenrus.com> (raw)
In-Reply-To: <Pine.LNX.4.56.0311141243030.19155@wotan.suse.de>

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

On Fri, 2003-11-14 at 14:09, Bernhard Kaindl wrote:

> The reason for the process hang seems to be the way loop_set_fd calls calls
> kernel_thread():
> 
>         kernel_thread(loop_thread, lo, CLONE_FS | CLONE_FILES | CLONE_SIGHAND);
>         down(&lo->lo_sem); <- This seems to wait for loop_thread()
> 
> Since kernel_thread can fail at the moment, all places where it is
> called would need to be checked and error handling added.

kernel_thread could fail even before, after all it allocates memory.
So this code has always been buggy just harder to trigger

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2003-11-14 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-13 21:55 Erik A. Hendriks
2003-11-14 13:09 ` Bernhard Kaindl
2003-11-14 13:29   ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1068816558.5206.0.camel@laptop.fenrus.com \
    --to=arjanv@redhat.com \
    --cc=bernhard.kaindl@gmx.de \
    --cc=hendriks@lanl.gov \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®