From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD8AF22FE0A for ; Tue, 25 Nov 2025 14:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764080181; cv=none; b=BCJT9gzCEKIGqyqDJoS1tjRrk7J3dAvIgd1LhQYyc9IE0QhBeaiFOsdHwotJ5POqauMMc+drY6aDSt/QqyeDxt1Ao3HiqjYsdBcNyfnQ3UtRCSj2Fy26PZeFwO7wc1+8CbdC1Pmd9+5dJ+Dw4FEhlSR/WxKxhrwUuG7fZw1+ygQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764080181; c=relaxed/simple; bh=fz8dUOLkrmuqWoT6oi5DtVb+2CmS9v+v6gFIhBnZfgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I2Ao2uwo1QQyka5qwyon7cyMr9/nyTMD0w+L4U+QkNpf9UzLo4W5lbg2TuXwe7MziF5NJ/ngP2IcLMyByW6+Khs7c0Sh5MiIWnofxDf0J/CT0bMav1xtaR23amG9nddPHqye5flXT8Y6yyZ4asbVfUEIWe0QGTsgYidQRWVPLC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Eyyjex0T; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CCGSpeLu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Eyyjex0T"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CCGSpeLu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764080178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cOVfHp9blK7VBhAWHvqJJVbO8Gp5yJ1ZNq+u6p5xQdY=; b=Eyyjex0T8gbHn7M0L+BrqJ44bJJIohT/WWSV13XGuiYrjHIg2XjnhFYfOOyVpKpDm83qwb NTarMNokrReue6+UqBy1pcmSw82Zc5mUyhqr8vN2wcX8suUUrZLiTeIozlJrb5vdNT+vfp frn45Wb3/Ng9bQa+MmZ0qhbcNhEsXnM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-EGo1RpJ4O0aZtifWAeMRAA-1; Tue, 25 Nov 2025 09:16:14 -0500 X-MC-Unique: EGo1RpJ4O0aZtifWAeMRAA-1 X-Mimecast-MFC-AGG-ID: EGo1RpJ4O0aZtifWAeMRAA_1764080173 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47777158a85so73375935e9.3 for ; Tue, 25 Nov 2025 06:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764080173; x=1764684973; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cOVfHp9blK7VBhAWHvqJJVbO8Gp5yJ1ZNq+u6p5xQdY=; b=CCGSpeLuZmHVdzmXrvN34Xh1zz2wNuFC5EnK1THbWJv+HZQGbykucwT3bRcDc1Hosw 4bMYYWjn8+vSd0GwDLoYuFi2m4sWMepp7J2U1jQxOvXyY3SbbivFmo+D9Bxp8sQyYG/w hf9xlJi5eLXfX8diJJewMImGNccxnpfZGZJ4idlbBbcJ1OxToTMqGS4+WrbMmoCizMpp ZNDgs1tpwIwNzMuFpixyvM4Emgpn5Ak8zompAmLeM0nVF1kNAHaNDtOqK1mW2GPhhphA dL413/icfm9EeKueWqu26ZVwqSdsvQNjuxd5TNwi3DRcwGF4+gwBFncRRdWTg119dd6C b5yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764080173; x=1764684973; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cOVfHp9blK7VBhAWHvqJJVbO8Gp5yJ1ZNq+u6p5xQdY=; b=iFZS0uNT2tBrTVSsTwiHtS2A7NFY92wWAAQpob9iB0P1UFLR8OyPgG1hwqeXmlybW4 OZ6dvCDQuhed0rEK6dnsR+iSKui9MHdMmywWwF5Jc2dMlKF6Uv8OCOb5mJ+l94eMtQgz XLi2QxAp7HRbwBrMPPSmGqbp9gCc7UbUJNbVnNOOhGx+JhNhc1NAp3kdpYEIBOOQKyRi W02kocpp3/9UR4bdSzZfzTuTQPxGj+75yfwqrNChdriyR4QeD6OsV26TaWqC4/tI1eAf jBZfIvTa8H/9eDdoisPodSpC+wmQmgSAOWnXS4Msn1pj7k2xvY31JJU9Rw9Jj5OReMMM O77w== X-Forwarded-Encrypted: i=1; AJvYcCWH/lAnIevl/itaFM83cT1C+AhmPccEx47T3iyhJhp9utvnPHGhtptQKGSsIunoKUbIrWailTH0ty8Bx4M=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn54vR44kMWOUE752UN++9fNCB08r7+g2z88wZtNfYbGHbeoSV cxB6HzpB8eJZx1yoRlOHNnkXbSImWuVz9aV1WAg7MKdgUsUXwFwiv2amIKvci4br4WhxYl/uSA3 Y32WmgLLlabFLzMa+JRnJoqfs2a3f1HL0325HLBZYq1+jRM5X/VTVj+NHCVlDgu0Nfw== X-Gm-Gg: ASbGnctsaaY5Rq7r1JKQgDbfUyzY6yyLkJvmpfBnLFZ2COT5lkav6NCriNGXrM2HMOi WlDu09v/yYJUr79T2YRh9aVKg6uzzZUDR2y+WIT4iMFvO1UZlVYIvkiB1rgIKvi2kRLPZf+NuVu JLFWIL2KAYEpul2VVzrFtmASCJfFbjwXWsHqq4OzVjPHVLZroBZUCem329lQrIcSyoB3x9ic5Ni Xgo/E+4kUjDl8RrEsWzXrnJHuWL4CocMHFdrYpbxYoBD3HJDQ+yLuYTlt+i5QOhEYQYeYXpY01L YuGO0wExMkvlSYAcAGxMr18dqSODKadrASW7OwlzK4T5lEC9nR2ZziWBXyY4RSn59YlcAruxQNu bw23HTJIx4aHJPw== X-Received: by 2002:a05:600c:35d1:b0:477:fcb:2267 with SMTP id 5b1f17b1804b1-477c10d6e76mr166439235e9.8.1764080172764; Tue, 25 Nov 2025 06:16:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9xDEm63fmzn5I9bRc4mGBEdTRc4fc7SlxHbBVsUfrg8G31SlrJq8hRiHKGxsIJ2OdDp0G/g== X-Received: by 2002:a05:600c:35d1:b0:477:fcb:2267 with SMTP id 5b1f17b1804b1-477c10d6e76mr166438925e9.8.1764080172349; Tue, 25 Nov 2025 06:16:12 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf226c2asm252052355e9.10.2025.11.25.06.16.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 06:16:11 -0800 (PST) Message-ID: <106cc1c2-3e7a-438f-a7c3-7d8804665cb5@redhat.com> Date: Tue, 25 Nov 2025 15:16:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 05/12] ipvlan: Make the addrs_lock be per port To: Dmitry Skorodumov , netdev@vger.kernel.org, Kuniyuki Iwashima , Jakub Kicinski , Xiao Liang , Eric Dumazet , Guillaume Nault , Julian Vetter , Stanislav Fomichev , Etienne Champetier , linux-kernel@vger.kernel.org Cc: andrey.bokhanko@huawei.com, Andrew Lunn , "David S. Miller" , Ido Schimmel References: <20251120174949.3827500-1-skorodumov.dmitry@huawei.com> <20251120174949.3827500-6-skorodumov.dmitry@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251120174949.3827500-6-skorodumov.dmitry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/20/25 6:49 PM, Dmitry Skorodumov wrote: > Make the addrs_lock be per port, not per ipvlan dev. > > This appears to be a very minor problem though. > Since it's highly unlikely that ipvlan_add_addr() will > be called on 2 CPU simultaneously. But nevertheless, > this may cause: > > 1. False-negative of ipvlan_addr_busy(): one interface > iterated through all port->ipvlans + ipvlan->addrs > under some ipvlan spinlock, and another added IP > under its own lock. Though this is only possible > for IPv6, since looks like only ipvlan_addr6_event() can be > called without rtnl_lock. > > 2. Race since ipvlan_ht_addr_add(port) is called under > different ipvlan->addrs_lock locks > > This should not affect performance, since add/remove IP > is a rare situation and spinlock is not locked on fast > paths. > > Also, it's quite convenient to have addrs_lock on > ipvl_port, to dynamically prevent conflict of IPs > with addresses on main port. > > CC: Paolo Abeni > Signed-off-by: Dmitry Skorodumov This really looks like a fix, that should go via the 'net' tree with a suitable fixes tag. /P