From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E923CFF53 for ; Fri, 18 Sep 2026 09:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789724323; cv=none; b=jkBMDn8eNaraP+Fbhme2ssdnGE99TAL/Asz7+tgJBbN6XFhm1pVCEfunACW54AFOiRGHnTYDhJi0HUSbtzkvINXOHJ6NEQxfTBfosQ3gDB3VLyYYSmqEEERC50LDaPkxq2WE4xk0XSfnXMS7ML8yhWfxktwuOZo0mMB3AkMri7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789724323; c=relaxed/simple; bh=EKwXtsJj3HIzl22R+w1NmBqtdM4TpOCuLFL3lkWRQDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GgNz3Y0M+273Ypr8N258LrfWKE+XtAU0NOZ7wKu6BdznFpZTqKqeYNtxVwCtaBF2QYKs1P0uueYLizDMqZnzfraWTo/xBqL8RCk2AiakYydiXQ7tOmxg0C+ey6swntkN0Pmz//+OX2PCK9raWKHO4NFBInOzg5d7AUqyERmNM34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SlfwPao3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FL2BnvG0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SlfwPao3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FL2BnvG0" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I60WtY021443 for ; Fri, 18 Sep 2026 09:38:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o7hJ13EQC/53rd2uiF8osBuU7DQ6FdTCoqbb9tdnLzY=; b=SlfwPao3KKFomVRp Ngdh9/IfPV5aFYHtUdQZk9l9ouTk9E+NFrIJA7cF3nDbuiIW++tsH0bxz1UUhbUl 7RL2/QqCLqQKocLpicnbcCyG5ZVHtapuGVZiIPtQORMNNgRgvCXZFzTx0EridiFP 1pqOANdX8T8apHtH5fTfClHRN/T7IyYCvzWsYzg8NG+gsAQ7yK5916z28+XVgoOP M0eslYLMfLMyOhev2KcGThSCaISwiVrbn1hpE0YH5SXs/foSQkCrzeC46oyKqdHe 90PB4xIG+9fj2optPdX+3F+H5JvUuCVOIiwul84KfqK8uCgazd1tJWjSNHi9LGBp 8isM5g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4grnqeb933-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 18 Sep 2026 09:38:40 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-934a8cd3a8bso13507885a.3 for ; Fri, 18 Sep 2026 02:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789724320; x=1790329120; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o7hJ13EQC/53rd2uiF8osBuU7DQ6FdTCoqbb9tdnLzY=; b=FL2BnvG01eE1P6ZKln4U6mtYz1OIgiyzO6wf6rYdYjYUfwII7pQAhBPczYqVt458Yw +OBnCierkGe4oZ6hhCfcuqjI16G+QIEQnPX2zn3Y/+7CvDKi0YWYVRFzVYeu1Z3eZNLl xItaV3iG9BwBD7louE4jBxCyvCe0z1/Zn1Ub2k7uhHZ0HFBjR9mji8hSlmW9C/mgYzL6 cOBqStsO8nBCWzC+6QxX2MAuTFcHOO+PafroLzSUcKhHsNcl2h45hjPDoihaksRFdgLK UWPM+b0niSQ9o/AgZZBnGVOLuQRtvXAENKDitqMkVLWLdSg1cJ0SULXkp84C9mKkBuDO u0dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789724320; x=1790329120; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o7hJ13EQC/53rd2uiF8osBuU7DQ6FdTCoqbb9tdnLzY=; b=fqPKZqASjlhmXO/O2sbUAXrXhTFRdpY3GyFqIXOzKqD6blaIJvYUEPhfm81cFyTuBV iDfDNfOtFg9BqmPEV4ay4onTdp04G32BO6sgHH3OxyPEtM9taIt7rrCOjIegddTp9Oy1 y1L/bOCTMcJsuEC5A16R0gUjFXeExwYvEY0iaXfPjEe+L9QGcEKnFJxE5ZA66bXEbQ4i Ea92lisFwfTnVNu9nao2woQwNSI5u5cKJdNBwscBGi0ZmKLS/EwgC2eYSmQYhD23o7BA NqQDzGCqqxKVFKpduB2qjyVgtrtIb9sPfryI/50NCSCxDARDVBlKLeqYTDmKy7oKjvJW dNzQ== X-Forwarded-Encrypted: i=1; AKwUvBy9udte2FKYrOELFUjezV5wdmlXleAnsuPKVRgO8q4XsqCjKuvIw7QqpsfZbsWhY/fu3EWIO5XPWzV2b0I=@vger.kernel.org X-Gm-Message-State: AFuF++nqWaOWZphf/9pa+NMwUMv8QUlJIkwAh17u6XjVb/H+PIzCkxU+ qqHg+4ugTHadIPvFHok6Vgpjmra5rmeVNyWTm8g95TEDmmcIGfvytTyfeFiexaw9jInC28sBOpi I6pGLj89YomZFREAIIYDGAhZUKDZccXE4a3CiO0E5d7eC++fz90Pnu6ftwrhZi8xcHFE= X-Gm-Gg: AYBFou0NTBBrx1k3H2G5+xkASszMxgs5ldTOaEolGjPSs7zO6W+WIusWUjwOVALT3RC 0YKDP/yY6xAiQUBohV/SFk+PJ49PdG+vxnUWf4Q5ESovgEsZkUcHweh9jowEnUNXxALFwIBTdTm 57IGbrI0YJfR5KE/9LnjAhp4Y9/j1haWYctyRB8CNghsIGoYCb3A6lhjhWRma0Pkt3XON4iy1OE J/kbJUcASmwCVNFWLA8R1q9ZMGOmx9hTRbgmoQx1YL1GNOlzP7pppBQInyejkdr30XnYgWLAUK7 U1qioqeJtS0iPuL/MhSuP6TOTtNHvtTICRLxcCLzHoOSq7wAZRS390CsKX3Ty0zEJB0RShpHJiw onDEjcjO6r9hUqM0kgRAplA== X-Received: by 2002:a05:620a:19a1:b0:936:2f59:dfe4 with SMTP id af79cd13be357-93be01ed0ccmr169689885a.0.1789724319957; Fri, 18 Sep 2026 02:38:39 -0700 (PDT) X-Received: by 2002:a05:620a:19a1:b0:936:2f59:dfe4 with SMTP id af79cd13be357-93be01ed0ccmr169687385a.0.1789724319508; Fri, 18 Sep 2026 02:38:39 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a1bb0712esm38386266b.17.2026.09.18.02.38.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2026 02:38:38 -0700 (PDT) Message-ID: <1070a7ca-1636-4b6f-af04-f7bb7829dcbb@oss.qualcomm.com> Date: Fri, 18 Sep 2026 11:38:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 27/48] clk: qcom: gcc-sm6375: Use common clock controller probe data To: Abel Vesa , Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-27-25a24e50f82a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-27-25a24e50f82a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Rj5QcANl5cXylIzrJZqIxHxOyAh7y1wx X-Authority-Analysis: v=2.4 cv=FfiiV5+6 c=1 sm=1 tr=0 ts=6aad06a0 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=bEL-nVXw9uPW1QxN0uEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: Rj5QcANl5cXylIzrJZqIxHxOyAh7y1wx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDEzMiBTYWx0ZWRfX/I9WmmXgbCln qEahxyLPaACvQJvZnMLoMXPfOZUP8WsHUCikA6ZqYow9C1VuueDx5xh+t3vJbQIAQUszX038LU3 Ok3H/+g/8YCpHVfZU5wA3OCEKpxKRkRL4Bz2EIo8ONaDNZOVRWKck6/vaxRcd09nhhC2VX1zZwb yNSVCNJsTg0Th+WL7UvzS0kiFW9dk+uUweQOi30CWw0VoOURSBYSKJjeTmmEnkqoBnCVZzqSu6u ACjWcL0t7HiKXZn7bOK97vq7icmxhQbHp2ZHDv0+Ky6L9/SZyaoLKqeDW8yXEqt4h2uHkdMUVYT Luy0l+G20yIz+kiqQamfvOY3zobJj30lBwCW3ga6W4rLwFT5TTiUqdtHXF6TUigWmjfwoFgfHLu 6JMJ1r8RLeI3oJK5tUtEJtT6vxqntlUWWqjPZyrixY/rgEdRn/XOdpMDLDWhdp/sMmElOoymfHG JhgZtNE+bexF3rew8zA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDEzMiBTYWx0ZWRfX0tyGqpoyZ8Eb EaWurO1PJnDhN3cg5PUW71EdFkwYadRHVgh/QQNIztiYcv+wemjzsM9pvbAABmZuF5+0f0uJAco TmtJ28aa66bnQGGQi/HcW8NPSAuU8/E= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_02,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180132 On 9/16/26 12:28 PM, Abel Vesa wrote: > Move the always-on branch register offsets into a critical_cbcrs array > and describe the DFS RCGs through qcom_cc_driver_data. > > Move the configuration of GPLL10, GPLL11, GPLL8 and GPLL9 into the > clk_regs_configure callback. This preserves the existing ordering of > enabling the always-on branches before configuring these four PLLs. > Using the alpha_plls array instead would configure the PLLs before the > CBCR enables in the common probe path. > > Use qcom_cc_probe() to perform the common initialization instead of > open-coding it in the driver's probe. > > Assisted-by: LLM > Signed-off-by: Abel Vesa > --- > drivers/clk/qcom/gcc-sm6375.c | 46 ++++++++++++++++++++++--------------------- > 1 file changed, 24 insertions(+), 22 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm6375.c b/drivers/clk/qcom/gcc-sm6375.c > index f47dc2808095..d125243ac6cb 100644 > --- a/drivers/clk/qcom/gcc-sm6375.c > +++ b/drivers/clk/qcom/gcc-sm6375.c > @@ -3853,7 +3853,30 @@ static const struct regmap_config gcc_sm6375_regmap_config = { > .fast_io = true, > }; > > +static const u32 gcc_sm6375_critical_cbcrs[] = { > + 0x17028, /* GCC_CAMERA_XO_CLK */ > + 0x2b004, /* GCC_CPUSS_GNOC_CLK */ > + 0x1702c, /* GCC_DISP_XO_CLK */ > +}; > + > +static void gcc_sm6375_regs_configure(struct device *dev, struct regmap *regmap) > +{ > + clk_lucid_pll_configure(&gpll10, regmap, &gpll10_config); > + clk_lucid_pll_configure(&gpll11, regmap, &gpll11_config); > + clk_lucid_pll_configure(&gpll8, regmap, &gpll8_config); > + clk_zonda_pll_configure(&gpll9, regmap, &gpll9_config); This should use the alpha helpers instead Konrad