mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@voxel.net>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] CONFIG_PCMCIA_PROBE fix
Date: Mon, 22 Dec 2003 00:48:44 -0500	[thread overview]
Message-ID: <1072072123.27831.6.camel@spiral.internal> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]

Some time ago, Russell King submitted a patch to use CONFIG_PCMCIA_PROBE
instead of CONFIG_ISA in pcmcia probing code.  Unfortunately,
CONFIG_PCMCIA_PROBE still is only set if CONFIG_ISA is set.  This means
that if ISA isn't enabled, certain things break in 2.6; for example, my
pcmcia nic/modem (using pcnet_cs/serial_cs).  These worked fine in 2.4;
I tracked the behavior to the fact that if irq_mask is set on a pcmcia
socket (instead of pci_irq), and PCMCIA_PROBE isn't set,
pcmcia_request_irq refuses to assign an irq.  Most of the pcmcia bridges
appear to set an irq_mask, so the attached patch changes Kconfig to set
CONFIG_PCMCIA_PROBE if any of those bridges are selected.

Please apply this (or an alternative fix), as it fixes a 2.6 regression
in pcmcia functionality.


[-- Attachment #1.2: 000-pcmcia_probe.patch --]
[-- Type: text/x-patch, Size: 1186 bytes --]

Revision: linux--mainline--2.6--patch-2
Archive: dilinger@voxel.net--2003-spiral
Creator: Andres Salomon <dilinger@voxel.net>
Date: Sun Dec 21 03:05:27 EST 2003
Standard-date: 2003-12-21 08:05:27 GMT
Modified-files: drivers/pcmcia/Kconfig
New-patches: dilinger@voxel.net--2003-spiral/linux--mainline--2.6--patch-2
Summary: Enable PCMCIA_PROBE on pcmcia bridges
Keywords: 

Current behavior only enables CONFIG_PCMCIA_PROBE if CONFIG_ISA is set.  Some
bridges (for example, yenta) break badly w/out PCMCIA_PROBE; w/out it,
pcmcia_request_irq() fails if an irq_mask is set.  The idea is to decouple
CONFIG_ISA from CONFIG_PCMCIA_PROBE; so, what I've done is to enable
PCMCIA_PROBE for bridges that set irq_masks for their sockets.

* added files

    {arch}/linux/linux--mainline/linux--mainline--2.6/dilinger@voxel.net--2003-spiral/patch-log/patch-2

* modified files

--- orig/drivers/pcmcia/Kconfig
+++ mod/drivers/pcmcia/Kconfig
@@ -103,7 +103,7 @@
 
 config PCMCIA_PROBE
 	bool
-	default y if ISA && !ARCH_SA1100 && !ARCH_CLPS711X
+	default y if !ARCH_SA1100 && !ARCH_CLPS711X && (ISA || YENTA || TCIC || HD64465_PCMCIA || I82365)
 
 endmenu
 




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2003-12-22  5:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-22  5:48 Andres Salomon [this message]
2003-12-22  9:48 ` Russell King
2003-12-22 17:18   ` Andres Salomon
2003-12-22 17:33     ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1072072123.27831.6.camel@spiral.internal \
    --to=dilinger@voxel.net \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®