From: Christophe Saout <christophe@saout.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Fruhwirth Clemens <clemens@endorphin.org>,
Joe Thornber <thornber@sistina.com>
Subject: Re: [PATCH 2/2][RFC] Add dm-crypt target
Date: Tue, 23 Dec 2003 14:36:22 +0100 [thread overview]
Message-ID: <1072186582.4111.46.camel@leto.cs.pocnet.net> (raw)
In-Reply-To: <20031223131355.A6864@infradead.org>
Am Di, den 23.12.2003 schrieb Christoph Hellwig um 14:13:
> Please include driver-private headers after kernel headers.
>
> > +struct crypt_c {
>
> crypt_context? The current name isn't very descriptive..
>
> > +static kmem_cache_t *_io_cache;
>
> Again a rather strange variable name. What about dm_crypt_pool?
>
> Please kill these superflous wrappers.
>
> > +static spinlock_t _kcryptd_lock = SPIN_LOCK_UNLOCKED;
> > +static struct bio *_bio_head;
> > +static struct bio *_bio_tail;
> > +
> > +static struct dm_daemon _kcryptd;
>
> Again, rather strange naming..
This was done to be consistent with the other device-mapper code. I can
change it though.
Joe?
--
Christophe Saout <christophe@saout.de>
Please avoid sending me Word or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
next prev parent reply other threads:[~2003-12-23 13:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 21:42 loop driver, device-mapper and crypto Christophe Saout
2003-12-22 21:49 ` [PATCH 1/2] Add dm-daemon Christophe Saout
2003-12-23 12:27 ` Christoph Hellwig
2003-12-23 15:10 ` Joe Thornber
2003-12-22 21:52 ` [PATCH 2/2][RFC] Add dm-crypt target Christophe Saout
2003-12-22 23:07 ` Jeff Garzik
2003-12-22 23:24 ` Mike Fedyk
2003-12-22 23:29 ` Jeff Garzik
2003-12-22 23:50 ` Mike Fedyk
2003-12-23 0:10 ` Christophe Saout
2003-12-23 2:53 ` Rusty Russell
2003-12-23 13:13 ` Christoph Hellwig
2003-12-23 13:36 ` Christophe Saout [this message]
2003-12-23 15:15 ` Joe Thornber
2003-12-23 15:31 ` Jeff Garzik
2003-12-23 15:43 ` Joe Thornber
2003-12-23 17:01 ` Christophe Saout
2003-12-23 17:15 ` Joe Thornber
2003-12-23 17:14 ` Jeff Garzik
2003-12-22 22:03 ` loop driver, device-mapper and crypto Andrew Morton
2003-12-23 11:14 ` Fruhwirth Clemens
[not found] <15G6g-4oz-17@gated-at.bofh.it>
[not found] ` <15Gg9-4H6-25@gated-at.bofh.it>
2003-12-22 22:29 ` [PATCH 2/2][RFC] Add dm-crypt target Andi Kleen
2003-12-23 15:11 ` Christophe Saout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072186582.4111.46.camel@leto.cs.pocnet.net \
--to=christophe@saout.de \
--cc=akpm@osdl.org \
--cc=clemens@endorphin.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thornber@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®