From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754545AbbFKPl4 (ORCPT ); Thu, 11 Jun 2015 11:41:56 -0400 Received: from forward12o.cmail.yandex.net ([37.9.109.179]:60385 "EHLO forward12o.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358AbbFKPlv (ORCPT ); Thu, 11 Jun 2015 11:41:51 -0400 X-Greylist: delayed 429 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Jun 2015 11:41:50 EDT From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Vignesh R , "akpm@linux-foundation.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Corbet Cc: Tony Lindgren , NeilBrown , Greg Kroah-Hartman , Fabian Frederick , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" In-Reply-To: <5562AFDB.1080701@ti.com> References: <1431950959-19606-1-git-send-email-vigneshr@ti.com> <5562AFDB.1080701@ti.com> Subject: Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode MIME-Version: 1.0 Message-Id: <1072261434036874@web13o.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 11 Jun 2015 18:34:34 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi 25.05.2015, 08:15, "Vignesh R" : >> šHDQ mode remains unchanged. >> >> šSigned-off-by: Vignesh R I have no experience with omap_hdq platform, but there are quite a few questions related to IO - you never check whether write was successful or read returned actually valid data, is it ok? I mean is it correct to assume that read can not return 0xff for example and it is a sign that something is wrong, or this can not happen? As for me, I have no objection, but this patch must go via omap tree imo.