From: Arjan van de Ven <arjanv@redhat.com>
To: "Durairaj, Sundarapandian" <sundarapandian.durairaj@intel.com>
Cc: linux-kernel@vger.kernel.org, "Seshadri,
Harinarayanan" <harinarayanan.seshadri@intel.com>,
"Kondratiev, Vladimir" <vladimir.kondratiev@intel.com>
Subject: Re: [patch] PCI Express Enhanced Config Patch - 2.6.0-test11
Date: Mon, 29 Dec 2003 12:53:39 +0100 [thread overview]
Message-ID: <1072698818.5223.21.camel@laptop.fenrus.com> (raw)
In-Reply-To: <6B09584CC3D2124DB45C3B592414FA8308C898@bgsmsx402.gar.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]
> diff -Naur linux-2.6_src/drivers/acpi/tables.c
> linux-2.6_pciexpress/drivers/acpi/tables.c
> --- linux-2.6_src/drivers/acpi/tables.c 2003-11-27 17:48:39.000000000
> +0530
> +++ linux-2.6_pciexpress/drivers/acpi/tables.c 2003-12-24
> 18:34:38.048354440 +0530
> @@ -58,6 +58,9 @@
> [ACPI_SSDT] = "SSDT",
> [ACPI_SPMI] = "SPMI",
> [ACPI_HPET] = "HPET",
> +#ifdef CONFIG_PCI_EXP_ENHANCED
> + [ACPI_MCFG] = "MCFG",
> +#endif
why this ifdef ?
> #define PCI_CFG_SPACE_SIZE 256
>
> +#ifdef CONFIG_PCI_EXP_ENHANCED
> +#define PCI_CFG_SPACE_EXP_SIZE 4096
> +#endif
or this one
> @@ -34,12 +46,22 @@
> new = file->f_pos + off;
> break;
> case 2:
> +#ifdef CONFIG_PCI_EXP_ENHANCED
> + if (is_pci_express_dev)
> + new = PCI_CFG_SPACE_EXP_SIZE + off;
> + else
> +#endif /*CONFIG_PCI_EXP_ENHANCED*/
this really looks like you want a dummy is_pci_express_dev (which is
forced 0) instead of all these ifdefs
> diff -Naur linux-2.6_src/include/linux/acpi.h
> linux-2.6_pciexpress/include/linux/acpi.h
> --- linux-2.6_src/include/linux/acpi.h 2003-11-27 17:47:18.000000000
> +0530
> +++ linux-2.6_pciexpress/include/linux/acpi.h 2003-12-24
> 18:34:21.000000000 +0530
> @@ -317,6 +317,15 @@
> char ec_id[0];
> } __attribute__ ((packed));
>
> +#ifdef CONFIG_PCI_EXP_ENHANCED
> +struct acpi_table_mcfg {
> + struct acpi_table_header header;
> + u8 reserved[8];
> + u64 base_address;
> +} __attribute__ ((packed));
> +#endif
why an ifdef around a struct definition ???
> enum acpi_table_id {
> @@ -338,6 +347,9 @@
> ACPI_SSDT,
> ACPI_SPMI,
> ACPI_HPET,
> +#ifdef CONFIG_PCI_EXP_ENHANCED
> + ACPI_MCFG,
> +#endif
> ACPI_TABLE_COUNT
> };
.... or an enum....
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-12-29 11:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-29 11:32 Durairaj, Sundarapandian
2003-12-29 11:53 ` Arjan van de Ven [this message]
2003-12-29 11:55 ` Christoph Hellwig
2003-12-29 12:51 ` Johan Sjoholm
[not found] <183UK-2Re-11@gated-at.bofh.it>
2003-12-29 19:12 ` Andi Kleen
2004-01-07 12:59 Durairaj, Sundarapandian
2004-01-07 14:08 ` Meelis Roos
2004-01-07 17:34 ` Vladimir Kondratiev
2004-01-07 16:44 Nakajima, Jun
2004-01-22 10:21 Durairaj, Sundarapandian
2004-01-22 10:44 ` Andrew Morton
2004-01-22 11:09 ` Martin Mares
2004-01-22 13:12 ` Andi Kleen
2004-01-22 18:21 ` Alan Cox
2004-01-22 19:40 ` Randy.Dunlap
2004-01-23 19:19 ` Pavel Machek
2004-01-23 19:31 ` Martin Mares
2004-01-23 20:08 ` Stefan Smietanowski
2004-01-22 16:40 ` Grant Grundler
2004-01-22 17:00 ` Greg KH
2004-01-28 9:38 Durairaj, Sundarapandian
2004-01-28 14:42 ` Vladimir Kondratiev
2004-01-28 14:54 ` Christoph Hellwig
2004-01-28 15:00 ` Martin Mares
2004-01-28 15:18 ` Matthew Wilcox
2004-01-29 11:32 Durairaj, Sundarapandian
2004-01-29 15:09 ` Matthew Wilcox
2004-01-29 15:59 ` Matthew Wilcox
2004-01-29 16:05 ` Linus Torvalds
2004-01-29 16:42 ` Matthew Wilcox
2004-01-29 16:52 ` Linus Torvalds
2004-01-31 21:57 ` Eric W. Biederman
2004-02-01 4:41 ` Grant Grundler
2004-02-01 5:10 ` Matthew Wilcox
2004-02-01 11:00 ` Eric W. Biederman
2004-02-01 15:18 ` Matthew Wilcox
2004-02-01 18:28 ` Eric W. Biederman
2004-02-01 20:11 ` Matthew Wilcox
2004-02-01 21:35 ` Eric W. Biederman
2004-02-01 11:10 ` Eric W. Biederman
2004-01-29 18:09 ` Greg KH
2004-01-30 16:33 ` Greg KH
2004-01-30 16:58 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072698818.5223.21.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=harinarayanan.seshadri@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sundarapandian.durairaj@intel.com \
--cc=vladimir.kondratiev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®