From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265528AbUABNAg (ORCPT ); Fri, 2 Jan 2004 08:00:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265531AbUABNAf (ORCPT ); Fri, 2 Jan 2004 08:00:35 -0500 Received: from websrv.werbeagentur-aufwind.de ([213.239.197.241]:52946 "EHLO mail.werbeagentur-aufwind.de") by vger.kernel.org with ESMTP id S265528AbUABNAe (ORCPT ); Fri, 2 Jan 2004 08:00:34 -0500 Subject: Re: [RFC][PATCH] Move bv_offset/bv_len update after bio_endio in __end_that_request_first From: Christophe Saout To: Jens Axboe Cc: Linux-Kernel Mailing List , Andrew Morton In-Reply-To: <20040102104637.GN5523@suse.de> References: <20040101173214.GA4496@leto.cs.pocnet.net> <20040102104637.GN5523@suse.de> Content-Type: text/plain Message-Id: <1073048438.4239.10.camel@leto.cs.pocnet.net> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Fri, 02 Jan 2004 14:00:39 +0100 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Am Fr, den 02.01.2004 schrieb Jens Axboe um 11:46: > > That's why I need to know exactly how many and which bvecs were completed > > in my bi_end_io function. > > > > Or do you think it is safer to count backwards using bi_vcnt and bi_size? > > I'm inclined to thinking that, indeed. Those two fields have a more well > established usage, so I think you'll be better off doing that in the > long run. Ok, if you say so. This and the IDE multwrite thing are the only two places in the kernel preventing bi_idx to be usable this way. I just thought it was nicer.