From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265391AbUAFDPR (ORCPT ); Mon, 5 Jan 2004 22:15:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265342AbUAFDPQ (ORCPT ); Mon, 5 Jan 2004 22:15:16 -0500 Received: from stat1.steeleye.com ([65.114.3.130]:8171 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S265339AbUAFDO4 (ORCPT ); Mon, 5 Jan 2004 22:14:56 -0500 Subject: Re: [BUG] x86_64 pci_map_sg modifies sg list - fails multiple map/unmaps From: James Bottomley To: "David S. Miller" Cc: Andi Kleen , Linux Kernel , SCSI Mailing List , gibbs@scsiguy.com In-Reply-To: <20040105190439.0a5f7370.davem@redhat.com> References: <200401051929.i05JTsM0000014248@mudpuddle.cs.wustl.edu.suse.lists.linux.kern el> <20040105112800.7a9f240b.davem@redhat.com.suse.lists.linux.kernel> <20040105130118.0cb404b8.davem@redhat.com> <20040105223158.3364a676.ak@suse.de> <1073347548.2439.33.camel@mulgrave> <20040106040640.1d2bcbd8.ak@suse.de> <20040105190439.0a5f7370.davem@redhat.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 (1.0.8-9) Date: 05 Jan 2004 21:14:45 -0600 Message-Id: <1073358887.2439.39.camel@mulgrave> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2004-01-05 at 21:04, David S. Miller wrote: > On Tue, 6 Jan 2004 04:06:40 +0100 > Andi Kleen wrote: > > > It's ok. I fixed the code now[1] If you have other undocumented requirements > > you should document them though, otherwise there may be more problems. > > Since merging is disabled by default now it won't trigger anyways. > > I totally agree with you Andi, not documenting this properly was an > oversight and not intentional. I'll go over the SCSI code and see if I spot any other lacunae in the API. James