From: David Woodhouse <dwmw2@infradead.org>
To: Rik van Riel <riel@redhat.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] some more fixes for inode.c
Date: Tue, 20 Jan 2004 13:46:37 +0000 [thread overview]
Message-ID: <1074606396.29472.6.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0401200803150.15071-100000@chimarrao.boston.redhat.com>
On Tue, 2004-01-20 at 08:06 -0500, Rik van Riel wrote:
> The first chunk refiles the inode on the inode_unused_pagecache
> list if needed,
Looks sane.
> but I'm not 100% sure we need that change, since
> maybe only completely unused inodes can end up here. David ?
No, I don't see any reason why that should be the case; you can get
iput() called for an inode which happens to have data in the page cache.
This part of the patch is needed.
--
dwmw2
next prev parent reply other threads:[~2004-01-20 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 13:06 Rik van Riel
2004-01-20 13:46 ` David Woodhouse [this message]
2004-01-20 13:52 ` Rik van Riel
2004-01-30 3:55 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074606396.29472.6.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®