Re: [PATCH] Incorrect value for SIGRTMAX

[eric.piel@tremplin-utc.net]

Quoting Andrew Morton <akpm@osdl.org>:


> b) it's casting the result of (foo > N) to unsigned which is nonsensical.
> 
> Your patch doesn't address b).
> 
> I don't thik there's a case in which sigev_signo can be negative anyway. 
> But if there is, the cast should be done like the below, yes?
God! I hadn't catch this one :-) Actually, the cast is needed because
sigev_signo is an int, this catches the (all fobidden) negative values.

Your patch is the right one :-)
Eric
 
> 
>  kernel/posix-timers.c |    3 +--
>  1 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN kernel/posix-timers.c~SIGRTMAX-fix kernel/posix-timers.c
> --- 25/kernel/posix-timers.c~SIGRTMAX-fix	2004-01-24 14:27:13.000000000
> -0800
> +++ 25-akpm/kernel/posix-timers.c	2004-01-24 14:28:21.000000000 -0800
> @@ -344,8 +344,7 @@ static inline struct task_struct * good_
>  		return NULL;
>  
>  	if ((event->sigev_notify & ~SIGEV_NONE & MIPS_SIGEV) &&
> -			event->sigev_signo &&
> -			((unsigned) (event->sigev_signo > SIGRTMAX)))
> +	    (((unsigned)event->sigev_signo > SIGRTMAX) || !event->sigev_signo))
>  		return NULL;
>  
>  	return rtn;
>