Re: [PATCH v5 2/4] arm64: dts: rockchip: Split out the common NanoPi RK3528 parts

[Jonas Karlman <jonas@kwiboo.se>]

Hi,

On 9/14/2026 10:24 AM, 安容 via B4 Relay wrote:
> From: 安容 <HystericalDragons@proton.me>
> 
> The FriendlyElec NanoPi Zero2 and the NanoPi R28S share their power
> tree, storage, RGMII Ethernet, RTC, SYS LED and debug console. Move
> those parts into rk3528-nanopi.dtsi so the NanoPi R28S can reuse them,
> and leave only the board specific nodes in the NanoPi Zero2 devicetree.
> 
> Suggested-by: Chukun Pan <amadeus@jmu.edu.cn>
> Signed-off-by: 安容 <HystericalDragons@proton.me>
> ---
>  .../boot/dts/rockchip/rk3528-nanopi-zero2.dts      | 307 +--------------------
>  arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi    | 304 ++++++++++++++++++++
>  2 files changed, 313 insertions(+), 298 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts
> index 97d85124d2..a8d99f983f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts

[snip]

> -
>  &usb_host0_ehci {
>  	status = "okay";
>  };
> @@ -347,23 +74,7 @@ &usb_host0_ohci {
>  	status = "okay";
>  };
>  
> -&usb_host0_xhci {
> -	extcon = <&usb2phy>;
> -	maximum-speed = "high-speed";
> -	phys = <&usb2phy_otg>;
> -	phy-names = "usb2-phy";
> -	status = "okay";
> -};

I suggest you keep all USB nodes in the device board files, NEO3 Plus
have USB 3.0 support and uses different configuration. So it will be
easier to get an overview if USB nodes are kept in the board DT.

Else most of this split matches what I played around with for U-Boot at
[1] a few weeks ago. I plan to send out the NEO3 Plus DT based on this
series later.

[1] https://git.u-boot-project.org/u-boot/contributors/kwiboo/u-boot/-/commit/40382468ba7ce9aa2e7dcde0e59003fd0d220b43

Regards,
Jonas

> -
> -&usb2phy {
> -	status = "okay";
> -};
> -
>  &usb2phy_host {
>  	phy-supply = <&usb2_host_5v>;
>  	status = "okay";
>  };
> -
> -&usb2phy_otg {
> -	status = "okay";
> -};

[snip]