mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Janne Pikkarainen <jaba@mikrobitti.fi>
To: linux-kernel@vger.kernel.org
Subject: Re: [Bug 1959] New: cs46xx driver mmap_valid 0-->1 in kernel 2.6?
Date: Thu, 29 Jan 2004 08:56:55 +0200	[thread overview]
Message-ID: <1075359415.10166.23.camel@cs90174.pp.htv.fi> (raw)

Hello everyone, I just subscribed to this list...

At Tue, 27 Jan 2004 07:14:40 -0800,
Martin J. Bligh wrote:
>> 
>> Is there a reason to keep mmap_valid=0 in cs46xx driver or is this a real bug? I
>> haven't seen any new bugs with this patch applied, all the multimedia
>> applications (mplayer, xine, xmms, noatun) keeps on working.

> cs46xx doesn't always support the direct hardware buffer.
> Only in some cases with a proper period (fragment) numbers, it can
> support the direct buffer access.  mmap_valid option forces the driver
> to allow OSS apps the direct accessing via mmap.  This might not work
> always, depending on the parameter the app uses.  Use at your own
> risk.
>
> In short: it's not a real bug as long as mmap_valid=1 option works.
> You had luck that your OSS apps (using mmap) seem working :)

If this is the case and if there are other applications affected by this
than Enemy Territory and Wine mentioned in bug #1959, maybe the 
"use mmap_valid 0/1" option should made selectable by the user in 
kernel menuconfig? Of course with the proper "Caution: selecting 
mmap_valid may cure some applications while hurting the others" warnings
attached.

I mean, for example I thought for a long time that cs46xx is much more 
badly broken in kernel 2.[56].x than it in reality seems to be. No new 
sound bugs ever since I've applied this mmap_valid 0-->1 patch and I 
think the first time I patched the driver was around 2.6.0-test1.

The sound card I have is Hercules SoundFusion Fortissimo III 7.1 
(or something like that).


             reply	other threads:[~2004-01-29  6:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-29  6:56 Janne Pikkarainen [this message]
2004-01-29 15:12 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1075359415.10166.23.camel@cs90174.pp.htv.fi \
    --to=jaba@mikrobitti.fi \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®