From: Panu Matilainen <pmatilai@welho.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tim Hockin <thockin@sun.com>, Linus Torvalds <torvalds@osdl.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: NGROUPS 2.6.2rc2
Date: Thu, 05 Feb 2004 00:11:35 +0200 [thread overview]
Message-ID: <1075932274.8336.10.camel@chip.laiskiainen.org> (raw)
In-Reply-To: <20040203221719.GA465@elf.ucw.cz>
On Wed, 2004-02-04 at 00:17, Pavel Machek wrote:
> Hi!
>
> > > Although I do believe that it would be better written as
> > >
> > > #define MAXGROUPS (1000) /* Arbitrary, but we have to limit it somehere */
> > >
> > > if ((unsigned) info->ngroups > MAXGROUPS)
> > > return -ETOOEFFINGLARGE;
> > >
> > > as I absolutely _despise_ code that tries to be too generic.
> > >
> > > What is it with CS classes that have removed "common sense" from the
> > > equation?
> >
> > OK, there are two easy answers to this. I can re-work it with a simple 32k
> > limit that needs to be recompiled to change, or I can add a sysctl to
> > control it (it appeared in an early version of this patch).
>
> I guess static limit is okay for this...
Maybe static limit is enough but it's more than just a bit annoying when
you hit that <limit>+1 mark. Oh well, just upping the current limit *a
lot* would make life easier for some of us.
- Panu -
next prev parent reply other threads:[~2004-02-04 22:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-27 22:53 Tim Hockin
2004-01-27 23:25 ` Dax Kelson
2004-01-27 23:55 ` Chris Wright
2004-01-28 0:41 ` Chris Wright
2004-01-28 0:46 ` Andrew Morton
2004-01-28 0:52 ` Christoph Hellwig
2004-01-28 1:02 ` Tim Hockin
2004-01-28 17:08 ` Hugh Dickins
2004-01-28 18:04 ` Hugh Dickins
2004-01-28 18:10 ` Linus Torvalds
2004-01-28 22:22 ` Tim Hockin
2004-02-03 22:17 ` Pavel Machek
2004-02-04 22:11 ` Panu Matilainen [this message]
2004-01-28 1:12 ` Rusty Russell
2004-01-28 11:31 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1075932274.8336.10.camel@chip.laiskiainen.org \
--to=pmatilai@welho.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rusty@rustcorp.com.au \
--cc=thockin@sun.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®