From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] unsafe reset in ac97_codec.c
Date: Thu, 05 Feb 2004 17:59:49 +0000 [thread overview]
Message-ID: <1076003988.15801.8.camel@dhcp23.swansea.linux.org.uk> (raw)
In-Reply-To: <1075998717.5204.1003.camel@cearnarfon>
On Iau, 2004-02-05 at 16:31, Liam Girdwood wrote:
> I agree, but I think we need to be aware of the codec type before we do
> a register reset. This type of codec is now becoming popular in PDA's.
Sometimes we can't even find out but yes I agree
> I can see another problem with the current probe implementation.
> Currently it sends the register reset command without first checking the
> codec ready bit. This assumes that the AC97 link is up and completely
> working before probe is called.
It is (in theory) the job of the calling driver to ensure AC97 is up
before doing the reset part.
> I'll implement this if it's acceptable as I can test it on both types of
> codec.
Sounds right to me
next prev parent reply other threads:[~2004-02-05 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-03 15:42 Liam Girdwood
2004-02-04 21:24 ` Jeff Garzik
2004-02-05 16:31 ` Liam Girdwood
2004-02-05 17:59 ` Alan Cox [this message]
2004-02-26 15:55 ` Liam Girdwood
2004-02-29 18:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1076003988.15801.8.camel@dhcp23.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=liam.girdwood@wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®