From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 539F8C25B5F for ; Wed, 16 Aug 2023 19:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345993AbjHPT6h (ORCPT ); Wed, 16 Aug 2023 15:58:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346005AbjHPT6L (ORCPT ); Wed, 16 Aug 2023 15:58:11 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5AA91BEE; Wed, 16 Aug 2023 12:57:47 -0700 (PDT) Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8D89666071BF; Wed, 16 Aug 2023 20:57:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1692215866; bh=FMkSrLQnK0fv59W1YNP5gvyExhodhHPfroxk6P347ts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TxkNLLmSy4yNx8xb1w/UCoaDppZS9oG1fLVkiOHuPJF62f+5oY0MQxhr5IcKYBM99 RsCiuZ1QIlMG/BNB4EBH6HBxsKtVMkzdSEJUcFfffi6cDhYOsC2aHBfkDHr3mL/YEF M0vXiAsq6rNNqk7Qzdstia4opWm4VLPvULlj5libNlu3JWCGmLswtOavtxCDCu4j74 L35yOR34cTWlYe/DUxdKpAWvNX6WtaVPnSPq17ip3+40sEGILhWetPEe9nEu5Jg7wp yjkzVEBm4Yjj/sencVpY0dEvFa3C8JUORYccPz82YQDNcKBNuoaLq7RSk1FUPFFmP3 PECPQU6PptiFQ== Date: Wed, 16 Aug 2023 15:57:40 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: daniel.lezcano@linaro.org Cc: Bernhard =?utf-8?Q?Rosenkr=C3=A4nzer?= , angelogioacchino.delregno@collabora.com, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org, ye.xingchen@zte.com.cn, p.zabel@pengutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, wenst@chromium.org, james.lo@mediatek.com, rex-bc.chen@mediatek.com, abailon@baylibre.com, amergnat@baylibre.com, khilman@baylibre.com Subject: Re: [PATCH v4 0/5] Add LVTS support for mt8192 Message-ID: <107678ff-c3d5-4c3a-ad0e-fa292a125daa@notapiano> References: <20230530195132.2286163-1-bero@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230530195132.2286163-1-bero@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 09:51:27PM +0200, Bernhard Rosenkränzer wrote: > From: Balsam CHIHI > > Add full LVTS support (MCU thermal domain + AP thermal domain) to MediaTek MT8192 SoC. > Also, add Suspend and Resume support to LVTS Driver (all SoCs), > and update the documentation that describes the Calibration Data Offsets. > > Changelog: > v4 : > - Shrink the lvts_ap thermal sensor I/O range to 0xc00 to make > room for SVS support, pointed out by > AngeloGioacchino Del Regno > > v3 : > - Rebased : > base-commit: 6a3d37b4d885129561e1cef361216f00472f7d2e > - Fix issues in v2 pointed out by Nícolas F. R. A. Prado : > Use filtered mode to make sure threshold interrupts are triggered, > protocol documentation, cosmetics > - I (bero@baylibre.com) will be taking care of this patchset > from now on, since Balsam has left BayLibre. Thanks for > getting it almost ready, Balsam! > > v2 : > - Based on top of thermal/linux-next : > base-commit: 7ac82227ee046f8234471de4c12a40b8c2d3ddcc > - Squash "add thermal zones and thermal nodes" and > "add temperature mitigation threshold" commits together to form > "arm64: dts: mediatek: mt8192: Add thermal nodes and thermal zones" commit. > - Add Suspend and Resume support to LVTS Driver. > - Update Calibration Data documentation. > - Fix calibration data offsets for mt8192 > (Thanks to "Chen-Yu Tsai" and "Nícolas F. R. A. Prado"). > https://lore.kernel.org/all/20230425133052.199767-1-bchihi@baylibre.com/ > Tested-by: Chen-Yu Tsai > > v1 : > - The initial series "Add LVTS support for mt8192" : > "https://lore.kernel.org/all/20230307163413.143334-1-bchihi@baylibre.com/". > > Balsam CHIHI (5): > dt-bindings: thermal: mediatek: Add LVTS thermal controller definition > for mt8192 > thermal/drivers/mediatek/lvts_thermal: Add suspend and resume > thermal/drivers/mediatek/lvts_thermal: Add mt8192 support > arm64: dts: mediatek: mt8192: Add thermal nodes and thermal zones > thermal/drivers/mediatek/lvts_thermal: Update calibration data > documentation > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 454 ++++++++++++++++++ > drivers/thermal/mediatek/lvts_thermal.c | 160 +++++- > .../thermal/mediatek,lvts-thermal.h | 19 + > 3 files changed, 631 insertions(+), 2 deletions(-) > > base-commit: 8c33787278ca8db73ad7d23f932c8c39b9f6e543 Hi Daniel, just a gentle reminder. As you've just applied [1], there are no longer any concerns with this series, and it'll provide both working interrupts and reliable thermal readings on MT8192. Thanks, Nícolas [1] https://lore.kernel.org/all/89fabd50-66ce-d94f-38c8-6dd6f343958d@linaro.org