From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Felipe Balbi <balbi@ti.com>,
Benoit Cousson <b-cousson@ti.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Mitch Bradley <wmb@firmworks.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rickard Andersson <rickard.andersson@stericsson.com>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH] drivers/pinctrl: grab default handles from device core
Date: Wed, 12 Dec 2012 23:26:59 +0100 [thread overview]
Message-ID: <10768446.F2JLuVrZNU@vostro.rjw.lan> (raw)
In-Reply-To: <CACRpkdbCuTAwqFVWkb7bx7_OAX_0PU8TjjbS879Ui30bdxXkQg@mail.gmail.com>
On Wednesday, December 12, 2012 08:56:41 PM Linus Walleij wrote:
> On Tue, Dec 11, 2012 at 7:13 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote:
> >> diff --git a/include/linux/device.h b/include/linux/device.h
>
> >> +#ifdef CONFIG_PINCTRL
> >> + struct dev_pin_info pins;
> >> +#endif
> >
> > Can't you just make this a * to the structure, saving a bit of space for
> > those that don't use this structure? Ok, it's only saving one pointer,
> > so it's really not a big deal to me if you don't want to do this, just
> > asking...
>
> OK I'll look into it.
I wonder if you could use a struct that will be empty if CONFIG_PINCTRL is
unset instead of using #ifdef around the field like this? [Kind of along the
lines of what I did for ACPI.]
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2012-12-12 22:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 13:40 Linus Walleij
2012-12-11 18:13 ` Greg Kroah-Hartman
2012-12-12 11:58 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 19:58 ` Linus Walleij
2012-12-12 19:56 ` Linus Walleij
2012-12-12 22:26 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10768446.F2JLuVrZNU@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=plagnioj@jcrosoft.com \
--cc=rickard.andersson@stericsson.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
--cc=wmb@firmworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®