mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neal Stephenson <neal@bakerst.org>
To: linux-kernel@vger.kernel.org
Subject: Tuner bug(?) and fix
Date: Tue, 17 Feb 2004 21:56:01 -0500	[thread overview]
Message-ID: <1077072961.23671.11.camel@moran.bakerst.org> (raw)

Hi,

	In 2.6.2, I noticed that my modprobe.conf line for tuner "options tuner
type=2" no longer worked. It even failed with insmod "insmod tuner.ko
type=2". dmesg reported

vmunix: tuner: chip found @ 0xc0
vmunix: tuner: type set to 19 (Temic PAL* auto (4006 FN5))
vmunix: tuner: type forced to 19 (Temic PAL* auto (4006 FN5)) [insmod]

I noticed that the a line had been removed from 2.6.1 and when it is
added everything works again. patch attached

--- -   2004-02-17 21:53:57.000000000 -0500
+++ /usr/src/linux-2.6.2-skas/drivers/media/video/tuner.c      
2004-02-17 21:39:06.000000000 -0500
@@ -1040,6 +1040,7 @@
  
         i2c_attach_client(client);
        if (type < TUNERS) {
+               t->type = type;
                printk("tuner: type forced to %d (%s) [insmod]\n",
                       t->type,tuners[t->type].name);
                set_type(client,type);



                 reply	other threads:[~2004-02-18  2:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1077072961.23671.11.camel@moran.bakerst.org \
    --to=neal@bakerst.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®