From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D47ED2F99AE for ; Sun, 21 Dec 2025 18:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766343175; cv=none; b=D/Poh9krkLJStCUdabIOOu8MryJj2V4K6pt5gcMfm1ZXIAqf/VVL8kMB0lKuQZ97mkd0FBS2uF3n2/AZ0MfLYVTwL/STVQCxthQc0HtY0j4kafC8bcpfBj/hH0KA8lrnQ4YOEjbeDswkxx5N0V9Lj5xAWB8bF7yvnaYi+/LFleM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766343175; c=relaxed/simple; bh=wTYyJ6KNs7lcO1LDw5mry706MHNd9SS12sadjX2FW+o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UPa6/4RwUr+VPXk41b0o86Q8/Z2rjtFlZ3OretNd0Atk+An4mmz9t0EC4YHo+ZwD7Ah8KmDqMt9cdpBb5kxJgkHuHe0JgMgjuhSjinhaJLtLZP2mzWd351GM7sjotTxxgx656/Pn61fxyys3M1gXhLBIKzl8AqKxGJq7BODVbtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KzfXdfh6; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KzfXdfh6" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47a95efd2ceso28597485e9.2 for ; Sun, 21 Dec 2025 10:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766343172; x=1766947972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EkFUuskD3aXQcMoKgf00kBQMcF6mPoLg5bi7MGfjH3A=; b=KzfXdfh6NwIpnEQ4xNJnZZg+yOATN0UgK0sDOfv83+I7tzjFOsfhCiCOfWou024bSY EMD90GWxJYj22UpfJPEDq+7Sg2rowa9AVgDxPZ/udfGKvDRk3CRtfoXY3v3DtZBM12Td DIDYD4f5mgRF5XliMEgO5SoNHPQBgJWoO4YkU4Wdmf8SiMSYrdd/bvBIrKeA8MfzDcjf wz/8t9zs0Cb5Kbc3mCPBqqmsVtgg5MOJXuBQZk5THfpGDCePrZfr7T8J/YMIiQ6MvL0q 5cV7C4bmeDJ4RCLxjRh1vmELDTuzCFUQt4lJukGsaW1HKDF5goh/KSCSN2c/Pl9fzt9d CQdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766343172; x=1766947972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EkFUuskD3aXQcMoKgf00kBQMcF6mPoLg5bi7MGfjH3A=; b=EB1RFL76tYhQehufg7aAr3Xfs/xHQ9iJufHGz2FLXLUInrHZk1iAcmu3PzY3at96rK KfLyeAlULhuyexBN0ajiY3E23EQnBTcHPtYf3UQdQcmPpWklJaHBGrKdu5q9znb1Oh8g NQTVO91RSnp2nNrs2g7zME0HWooSs4eYsvRTMcDFFrpcByAzQB68gv+j8Xcn9X4o6JaV Jw2sNUI9snf37aq1eI5rtGWKkV9LJ6nKHwdonTYB1ptw3rti4ko1i9IHBHUffQQjgF+L rMi7emoPmYsjwrkAoi9x8gu8AHNBZdaxZvAeMZhBXaH3AqXwiXGcivJb+/uI/gnrEidQ vejw== X-Forwarded-Encrypted: i=1; AJvYcCVJAllTg2CrvcpT2kf4Hz0R4Dn7Etfqysr/Py8HbBeO9E3k9ntDYZYoyz10TuEq/UOYKiGIabm1UxPPAtI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4maRkmiezgqASI8vMHCJIVtQY1ne8ChaBcmtl7x9Q/YjLg1VG qm9FNKC3mf0nWu3Pc+sjRdk2mrvyt3cpDaIqat/FzueflaTJHoTDSuc5 X-Gm-Gg: AY/fxX61ee+uB4Z/29TSSVZf47f2RojXrvjoR3M48K3YdPWeoPbEhtMFKm0MEcg27Nh 1gJF+h0Q2TVU6NieuMtOsYrFM1weXdxtbSveI3dV35yIvSZiFtK81jzI4ol8VtduNF0D61zzmyL 2Ba98teTlkRbChXnvyIEcwX2JFec1EVhiJEpZhIClLvkHbO7QOkdKmPSwpVAJO9aotXAC88SVIi Pz+b6nF7qYZUZ8qV91minPtxRqFAa9IL1kQaA5lo94Q3vRoUG/UP1TNnUfUXWrFv+sLhqddGViB byM2XiQTg82UCzvi8Axz3pq6OEGOCDavxob88hPYPLst37Ti7ni+ico0ZN4ulCHjGvbscXr8Odv 5KOdFU9dykEPICsyPXneI93dyBPcDfE4H1kpAhqiyMSvfoL/waudzRT5XED03bIdyIkS8X0zuvn E73lwMIlQTpGvTFuO+2B+WHlqJhvxWNarQD8da0+zEDktiM8N4V5wZgz2HfhJ/eWBCg5o9 X-Google-Smtp-Source: AGHT+IEkkDr9J9+zdibSJ3aQ9iWL0xgIJ5GrJUheHH61EjSouzXE+O5/goeHQ+aazrE5IYrzxVO9HA== X-Received: by 2002:a05:6000:4008:b0:430:f241:a11f with SMTP id ffacd0b85a97d-4324e4fa8a7mr8787306f8f.30.1766343171984; Sun, 21 Dec 2025 10:52:51 -0800 (PST) Received: from jernej-laptop.localnet (82-192-45-213.dynamic.telemach.net. [82.192.45.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4325d10cc48sm7775667f8f.16.2025.12.21.10.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 10:52:51 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Philipp Zabel , Richard Genoud Cc: Thomas Petazzoni , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Genoud , Krzysztof Kozlowski Subject: Re: [PATCH v2 1/4] dt-bindings: pwm: allwinner: add h616 pwm compatible Date: Sun, 21 Dec 2025 19:52:50 +0100 Message-ID: <10771871.nUPlyArG6x@jernej-laptop> In-Reply-To: <20251217082504.80226-2-richard.genoud@bootlin.com> References: <20251217082504.80226-1-richard.genoud@bootlin.com> <20251217082504.80226-2-richard.genoud@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne sreda, 17. december 2025 ob 09:25:01 Srednjeevropski standardni =C4=8Da= s je Richard Genoud napisal(a): > Allwinner H616 PWM block is quite different from the A10 or H6, but at > the end, it uses the same clocks as the H6; so the sun4i pwm binding can > be used. > It has 6 channels than can generate PWM waveforms or clocks if bypass is > enabled. >=20 > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Richard Genoud > --- > .../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pw= m.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml > index 1197858e431f..4f58110ec98f 100644 > --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml > +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml > @@ -14,6 +14,9 @@ properties: > "#pwm-cells": > const: 3 > =20 > + "#clock-cells": > + const: 1 Why #clock-cells? I don't see any reason to add it. Other properties seem fine. Best regards, Jernej > + > compatible: > oneOf: > - const: allwinner,sun4i-a10-pwm > @@ -36,6 +39,7 @@ properties: > - const: allwinner,sun50i-h5-pwm > - const: allwinner,sun5i-a13-pwm > - const: allwinner,sun50i-h6-pwm > + - const: allwinner,sun50i-h616-pwm > =20 > reg: > maxItems: 1 > @@ -62,7 +66,9 @@ allOf: > properties: > compatible: > contains: > - const: allwinner,sun50i-h6-pwm > + enum: > + - allwinner,sun50i-h6-pwm > + - allwinner,sun50i-h616-pwm > =20 > then: > properties: > @@ -83,6 +89,17 @@ allOf: > clocks: > maxItems: 1 > =20 > + - if: > + not: > + properties: > + compatible: > + contains: > + const: allwinner,sun50i-h616-pwm > + > + then: > + properties: > + "#clock-cells": false > + > required: > - compatible > - reg >=20