From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752010AbcFGCun (ORCPT ); Mon, 6 Jun 2016 22:50:43 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:50041 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbcFGCum (ORCPT ); Mon, 6 Jun 2016 22:50:42 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 06 Jun 2016 19:46:38 -0700 From: Stefan Agner To: Meng Yi Cc: Alexander Stein , linux-kernel@vger.kernel.org, Mark Brown , dri-devel@lists.freedesktop.org, David Airlie , airlied@redhat.com Subject: RE: fsl-dcu not works on latest "drm-next" In-Reply-To: References: <20160525104103.GV8206@sirena.org.uk> <2397536.bIp6BuhYPD@ws-stein> <17f0bd63a0efebefb30f10ff208da9bd@agner.ch> Message-ID: <10773f1a55f10edeb22f56a4e2b42b97@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-06-06 19:16, Meng Yi wrote: > Hi Stefan, > > Sorry for reply late, I was on PTO. And another PTO on June 9~11, 2016.UTC+8 > >> >> static const struct regmap_config fsl_dcu_regmap_config = { >> >> .reg_bits = 32, >> >> .reg_stride = 4, >> >> .val_bits = 32, >> >> .cache_type = REGCACHE_RBTREE, >> > >> > This needs to be a flat cache. See >> > https://lists.freedesktop.org/archives/dri-devel/2016-January/099121.h >> > tml or https://lkml.org/lkml/2016/3/24/281 >> > max_register also needs an appropriate value. >> >> Ok, since the complete set which switches to the atomic helper is not stable >> material (and also won't make it into 4.7 anymore), I created a seperate bugfix >> now: >> https://lists.freedesktop.org/archives/dri-devel/2016-June/109625.html >> > > What is bug? > The bug is that we should not use REGCACHE_RBTREE for MMIO registers... -- Stefan