From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F14E63C09FF for ; Tue, 30 Jun 2026 19:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782846739; cv=none; b=L8aWpYmnTScuzpq6ao+7mUF0w3KMvrjEkddEgjanfu1C3KK1pdFR8VTdXEPVr6LbJloz3bWdx9fH4AUX3o6MZYn/VN//Br/DudTTUoYV/mmkStEoOV5ktj/sbAaEZ82wXnzfVKK6AbAKVkS2VwWIlW7d7bsvwu61cxs1ZpS4ep4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782846739; c=relaxed/simple; bh=/DSEQ2xqYIgfitDaGNpIeKt/o9+rudLGDg3Ye72WEdQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J2VIGHB3YlsUpO2Fx/CwV17CaIKmhp/3Bmt3u2jNlFLd3urd8q7H/LuqAuXAhbGa/904Na/77YGkR6h1ytILjYFDXlEstv5X7a9JqFa30cgFG0EWTqlZZ93K900/ecakY73m6etYghrPQ/RY9jWCY6odqzfPRkzLZ2Hu1UUH/5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h8FiTwVz; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h8FiTwVz" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-139f3eaaa49so2617613c88.0 for ; Tue, 30 Jun 2026 12:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782846737; x=1783451537; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IVpHEl9caU7T4hBYJyvId9w6cxuR9iSE9E9+LhoY3dk=; b=h8FiTwVzy/Pv2da/r28WlnN8m+rl2iGXDrC4Ii/Q1bhttwb9WctB+H1z+tTKwC9yDs QufW4ZqTJQjsGkmxMJh+iqDp5rXzsZ4ozpo3wV2teuDZE80odVmKMhk5/EusWMdN2MI/ 1HZSWrDjp+S4FvG1bwVwhh05rKI9U6LBaAGzorKn+9KdHP0e8UKwN9S6diEHYFNj7B6J hvRIOM6YmY1xRjstTqVEI/Yyni2gCnA73wDU28zp+fvH6OdmJaCGJsmWXdoppb3jyu7G R2OR/Nd6UbkmkpnKiAYqs53ZjJ4+k7GnYBlGzXDHTmRqo99+Opej/cgHlp84wejwFbuy pkZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782846737; x=1783451537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IVpHEl9caU7T4hBYJyvId9w6cxuR9iSE9E9+LhoY3dk=; b=ZMKiKkGpNiU1UCxzVlCn5er5g3m4nVVZW4PzNxrK4d4gP5JVnbB1QHOMjHXHN8KjeR u/7tKQLUaXB1csZXOGHCOOyDk3Z68cvlJJ5ue5DT4pO9xYn9+XLQkiYAZg8JMTAA7gWg ZA9I50uXv9W31itWImVkVPKYL+c3C+cjSU6pvgxpKNEsHMPRaC49wV5fxfwcCAmrcUr2 Irxz+tsoF4KMelk81AaiHEj7zMz9YQrKNZo8ndhrXFCaX0AXs9OtgOcbGsJfVBYcDqAr 1aCZjP6HNGU0Mek0f28589mPre4MiCC3a8EfWjQ0i7j/xkJeMc/oig/FYjI3yMcksTDV L1lQ== X-Forwarded-Encrypted: i=1; AFNElJ8sXO47C2HNOcg+lqPtG5SicjqH3AGP5GldrCAcayvZnC3Ha581LPfKIcVtbrwRBrBZ0uyK8aBu1UN+sK0=@vger.kernel.org X-Gm-Message-State: AOJu0YyizLbu8PoQJUq8Gw61//ytlFKo3HZcRmd7jqz8lTxKIQMRU+nK fkCu0W9DaY58e+GHPH1urfbtIe+VLazzyw8sXECjF4d4v5Ht+ERXBEUksMqY5yTF X-Gm-Gg: AfdE7cl18fo2gOmoRHeeZBlVl1cA3yG45lQKYJGYZbdsrpvmYiNGwCGiAhG6zBKITzS XisLpqvIzWmrcBOGXhUL4pLHGyW8T3LGDxr/tnLJ5/EkLJEAg4PqstFRk/ORyASBqgvKX0C8ell GTC8D5WgqTc+ot7jUgmkH/uh+dCs40/FMQBkBQXSfcjqRapAJ3Gju1LUew55mBiXwgTsAdmUV3u 66CnW1LKpi6rWsFzASd9AYDkV1VvuS7yy/ONS0Ho69nRrh8HvJZeATEMo51Z+wHkD7rDZQgRQXF rKyBUHOob8YEmpf2lJRUOYYNmM1bOqra01k8EruskWOnjDMoZfzgR2cxfyCkTlEWneqO4xoLxAg JbZohsRU4liCvvpLkubdGzw/+uc+LQbHbLkase2A0cJPLH9tGIbARdiNaeJ5VWMGYiaDsfPqGha 1DG1RnIHDwkPFax9PMIJk2I2rRAPU8jy8gEq76ThZYVUoqni0V5a4KC0A3hpJvQvjpBH++5Nkna rnP6qnj6qODMc0+gsY3FuhFPrLRD9YU9nNOH7XWtNxuxTU= X-Received: by 2002:a05:7022:fa6:b0:136:d029:459 with SMTP id a92af1059eb24-13b3143a23emr1236125c88.22.1782846737048; Tue, 30 Jun 2026 12:12:17 -0700 (PDT) Received: from [192.168.1.240] (172-1-152-236.lightspeed.irvnca.sbcglobal.net. [172.1.152.236]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b2ab2e0e3sm10797161c88.7.2026.06.30.12.12.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 12:12:16 -0700 (PDT) Message-ID: <10777a10-c65c-4dd0-b4ba-00d94351aaf1@gmail.com> Date: Tue, 30 Jun 2026 12:12:09 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] scsi: lpfc: Add rport validation in lpfc_dev_loss_tmo_callbk To: Vaibhav Nagare , justin.tee@broadcom.com Cc: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Vaibhav Nagare , "paul.ely@broadcom.com" References: <20260629190108.601212-1-vnagare@redhat.com> Content-Language: en-US From: Justin Tee In-Reply-To: <20260629190108.601212-1-vnagare@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Vaibhav, 1.) This patch looks like it was rebased on top of the first version of this patch instead of off the tree. 2.) lpfc_dev_loss_tmo_callbk is the .dev_loss_tmo_callbk routine for scsi transport layer to call into our driver when dev_loss_tmo event is detected.  A null ndlp->vport in lpfc_dev_loss_tmo_callbk is somewhat unexpected.  Rather than checking for a stale pointer, it is more likely that an ndlp kref accounting race caused the vport ptr to be freed before lpfc_dev_loss_tmo_callbk was called. Is it possible to share the vmcore’s dmesg.txt file so that we may examine the root cause of the stale ndlp->vport ptr? Regards, Justin