From: Christophe Saout <christophe@saout.de>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix small highmem bio bounce bvec handling glitch
Date: Thu, 26 Feb 2004 16:06:06 +0100 [thread overview]
Message-ID: <1077807966.10397.2.camel@leto.cs.pocnet.net> (raw)
Hi,
[Oops, forgot to Cc LKML]
while going through the bio highmem handling code I noticed a small
glitch. __end_that_request_first might modify the bv_offset and bv_len
if the segment was partially completed. The bio-read-bounce-back code
should use the unmodified bv_offset when copying the segment data:
--- linux.orig/mm/highmem.c 2004-01-21 19:08:45.000000000 +0100
+++ linux/mm/highmem.c 2004-02-26 15:47:14.574722576 +0100
@@ -294,7 +294,12 @@
if (tovec->bv_page == fromvec->bv_page)
continue;
- vfrom = page_address(fromvec->bv_page) + fromvec->bv_offset;
+ /*
+ * fromvec->bv_offset and fromvec->bv_len might have been
+ * modified by the block layer, so use the original copy,
+ * bounce_copy_vec already uses tovec->bv_len
+ */
+ vfrom = page_address(fromvec->bv_page) + tovec->bv_offset;
bounce_copy_vec(tovec, vfrom);
}
next reply other threads:[~2004-02-26 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 15:06 Christophe Saout [this message]
2004-02-26 15:10 ` Jens Axboe
2004-02-26 15:30 ` Christophe Saout
2004-02-26 15:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077807966.10397.2.camel@leto.cs.pocnet.net \
--to=christophe@saout.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®