From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: James Simmons <jsimmons@infradead.org>
Cc: arief# <arief_m_utama@telkomsel.co.id>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Radeon Framebuffer Driver in 2.6.3?
Date: Sat, 28 Feb 2004 12:37:21 +1100 [thread overview]
Message-ID: <1077932239.23405.71.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.44.0402280048120.2216-100000@phoenix.infradead.org>
> Rememeber we have to modify every driver then to support FB_ACTIVATE_FORCE.
> You have to ask yourself what do you want to do exactly?
No we don't. Only fbmem, and that's part of the patch. What we could
do is strip the FB_ACTIVATE_FORCE (and actually clear out the
activate field completely) when copying to the driver's var structure
in fb_set_var().
In fact, we should certainly fix fb_set_var to _ignore_ the activate
field when comparing the var structures... this is a bug in the
current version imho.
It's a bit difficult to fix it while keeping memcmp, except if we do
a local copy of the var structure, which would eat stack space...
One problem with unblank is that it can be called at interrupt time,
but I don't think that ever happens with mode_switch set to true.
So we may just kmalloc a local copy of the var...
Ben.
next prev parent reply other threads:[~2004-02-28 1:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-27 6:27 arief#
2004-02-27 7:04 ` Benjamin Herrenschmidt
2004-02-27 10:06 ` arief#
2004-02-27 9:56 ` Benjamin Herrenschmidt
2004-02-27 10:45 ` Zilvinas Valinskas
2004-02-27 17:19 ` Mike Houston
2004-02-27 18:00 ` James Simmons
2004-02-27 22:43 ` Benjamin Herrenschmidt
2004-02-28 0:58 ` James Simmons
2004-02-28 1:37 ` Benjamin Herrenschmidt [this message]
2004-03-02 0:22 ` James Simmons
2004-03-02 0:26 ` Benjamin Herrenschmidt
2004-03-02 3:08 ` Paul Jackson
2004-03-02 7:50 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077932239.23405.71.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=arief_m_utama@telkomsel.co.id \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®