From: Matthew Dobson <colpatch@us.ibm.com>
To: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [TRIVIAL] Use valid node number when unmapping CPUs
Date: Mon, 15 Mar 2004 14:19:37 -0800 [thread overview]
Message-ID: <1079389177.3836.12.camel@arrakis> (raw)
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
The cpu_2_node[] array for i386 is initialized to all 0's, meaning that
until modified at CPU bring-up, all CPUs are mapped to node 0. When
CPUs are brought online, they are mapped to the appropriate node by
various mechanisms, depending on the underlying hardware. When we unmap
CPUs (hotplug time), we should return the mapping for the CPU that is
going away to its original state, ie: 0. When this code was initially
submitted, the misguided poster (me) made the mistake of putting a -1 in
the cpu_2_node[] array for the CPU going away. This patch fixes this
mistake, and allows code to get a valid node number for all valid CPU
numbers. This is important, because most (if not all) callers do not
error check the value returned by the cpu_to_node() macro, and they
should not have to. The API specifies that a valid node number be
returned for any valid CPU number.
-Matt
[-- Attachment #2: use_valid_nodenum.patch --]
[-- Type: text/x-patch, Size: 590 bytes --]
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.4-vanilla/arch/i386/kernel/smpboot.c linux-2.6.4-valid_node_unmap/arch/i386/kernel/smpboot.c
--- linux-2.6.4-vanilla/arch/i386/kernel/smpboot.c Wed Mar 10 18:55:27 2004
+++ linux-2.6.4-valid_node_unmap/arch/i386/kernel/smpboot.c Mon Mar 15 13:59:49 2004
@@ -522,7 +522,7 @@ static inline void unmap_cpu_to_node(int
printk("Unmapping cpu %d from all nodes\n", cpu);
for (node = 0; node < MAX_NUMNODES; node ++)
cpu_clear(cpu, node_2_cpu_mask[node]);
- cpu_2_node[cpu] = -1;
+ cpu_2_node[cpu] = 0;
}
#else /* !CONFIG_NUMA */
reply other threads:[~2004-03-15 22:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1079389177.3836.12.camel@arrakis \
--to=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®