From: James Bottomley <James.Bottomley@steeleye.com>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix removable USB drive oops
Date: 18 Mar 2004 08:36:11 -0500 [thread overview]
Message-ID: <1079616973.2021.5.camel@mulgrave> (raw)
In-Reply-To: <20040318005838.GA25884@kroah.com>
On Wed, 2004-03-17 at 19:58, Greg KH wrote:
> Bah, this was my fault, sorry.
>
> Here's a patch that should fix this, and prevent you from needing this
> patch. Can you verify this?
No, no. It was Martin's fault: He used a NULL class to indicate that we
had no transport class.
The registration code in SCSI looks like:
if (sdev->transport_classdev.class) {
error = class_device_add(&sdev->transport_classdev);
i.e. only add the device if we actually have a transport class. The
oops was caused because the unregister code was unconditional (i.e.
unregister a device we never registered in the first place). The patch
(among other things) makes it conditional on the
sdev->transport_classdev.class like the registration.
James
prev parent reply other threads:[~2004-03-18 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200403141810.i2EIAtK9032222@hera.kernel.org>
2004-03-18 0:58 ` Greg KH
2004-03-18 13:36 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1079616973.2021.5.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®