mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell Cattelan <cattelan@xfs.org>
To: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Small bug in bio_clone?
Date: Fri, 19 Mar 2004 16:11:09 -0600	[thread overview]
Message-ID: <1079734269.3373.42.camel@naboo.americas.sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Shouldn't __bio_clone be checking the state flags
of the src bio?

--- /usr/tmp/TmpDir.29150-0/fs/bio.c_1.3        2004-03-19
16:07:12.000000000 -0600
+++ fs/bio.c    2004-03-19 16:06:24.348491070 -0600
@@ -225,7 +225,7 @@
         */
        bio->bi_vcnt = bio_src->bi_vcnt;
        bio->bi_idx = bio_src->bi_idx;
-       if (bio_flagged(bio, BIO_SEG_VALID)) {
+       if (bio_flagged(bio_src, BIO_SEG_VALID)) {
                bio->bi_phys_segments = bio_src->bi_phys_segments;
                bio->bi_hw_segments = bio_src->bi_hw_segments;
                bio->bi_flags |= (1 << BIO_SEG_VALID);


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2004-03-19 22:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19 22:11 Russell Cattelan [this message]
2004-03-20 10:17 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1079734269.3373.42.camel@naboo.americas.sgi.com \
    --to=cattelan@xfs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®