From: Robin Murphy <robin.murphy@arm.com>
To: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Ryan Grachek <ryan@edited.us>,
Alistair Strachan <astrachan@google.com>,
Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
"stable #4 . 17+" <stable@vger.kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC"
Date: Thu, 24 Jan 2019 11:18:42 +0000 [thread overview]
Message-ID: <107a6e2e-ddd8-cbc1-5680-1b5899665327@arm.com> (raw)
In-Reply-To: <1548273966-5889-1-git-send-email-john.stultz@linaro.org>
Hi John,
On 23/01/2019 20:06, John Stultz wrote:
> From: Alistair Strachan <astrachan@google.com>
>
> This reverts commit abd7d0972a192ee653efc7b151a6af69db58f2bb. This
> change was already partially reverted by John Stultz in commit
> 9c6d26df1fae ("arm64: dts: hikey: Fix eMMC corruption regression").
>
> This change appears to cause controller resets and block read failures
> which prevents successful booting on some hikey boards.
FWIW, you might want to have a play with the pinctrl settings - I've
seen various flakiness with HS200 eMMCs on Rockchip boards which could
be solved by bumping up the drive strength.
Robin.
> Cc: Ryan Grachek <ryan@edited.us>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: stable <stable@vger.kernel.org> #4.17+
> Signed-off-by: Alistair Strachan <astrachan@google.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 6102350..7092460 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -300,7 +300,6 @@
>
> dwmmc_0: dwmmc0@f723d000 {
> cap-mmc-highspeed;
> - mmc-hs200-1_8v;
> non-removable;
> bus-width = <0x8>;
> vmmc-supply = <&ldo19>;
>
next prev parent reply other threads:[~2019-01-24 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 20:06 John Stultz
2019-01-24 11:18 ` Robin Murphy [this message]
2019-01-25 17:41 ` John Stultz
2019-02-01 16:36 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=107a6e2e-ddd8-cbc1-5680-1b5899665327@arm.com \
--to=robin.murphy@arm.com \
--cc=astrachan@google.com \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryan@edited.us \
--cc=stable@vger.kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®