From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FD5E3B1BD for ; Sun, 23 Nov 2025 16:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763917174; cv=none; b=ajaae7/A+KY5bTzL+32WG2V+KIb1942qr3LX55VL6kNqGIkcSBMSH9aoxryJWLu6AJTUuH50Rdfe+eHYLsqqFnuZNPiNc6BNUOgy6LTN59csT4QzW7ZQWxr1bbHyMnmbpwIGMIyeqZPd1l6kr8O/YxamjCyiPkY9iBwwxxNZBo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763917174; c=relaxed/simple; bh=gK55IaifKDN3ZrobdpVRFErmsNsHjkXbdgOYMV5Z/Bk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YdiaCQoaa3tb7rejxPnswzbDa0ejJgRcO4aU9kh9t/NDV/LYEuDsY0a8Zpp7RmX9QQZkkFzN62oEYN96tpmHDnuODYS2bRJb5NPUQrwekdx+OkQJXW1MASftuK2Vvmzst3FUzUJplF2MdWj/0wbIO1hRj81AuRhH8G7sjWgY5zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QqkNZXRo; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QqkNZXRo" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42b2a0c18caso2192764f8f.1 for ; Sun, 23 Nov 2025 08:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763917171; x=1764521971; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LPfV6chxQYs/pIoSdBBNjrnmPnwcnA8KYYwwlseA8DM=; b=QqkNZXRoDB/6VhBq1Pl817eBLyMqWFtb+mE+7AHtPrWV3TmSONmgL6cmyFekO4ebzH c+el2bSWw9YHO0nfa/LJFTuCu+F2gVr01o1ym5iC2uq4fmnL5txAGh6DNdbDqCIVT35r aa9pVICLDpOBPi0aH2tkZIWymCwdyFQo24MJBncHNtP119GS4Mu2nCMuscn15FAZLG/2 N/RUhaRlWmDd06sCP0O+mUaNyb12TqPff40cAQhkJHl5tq26+QjTdJfr7SEWnjdvMZa7 krAOqQyYb61X5tmGu4tHCaR0z8o5CmximX38CenKG2xith79pSrtUqd036HKGRLnSTuE Gcvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763917171; x=1764521971; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LPfV6chxQYs/pIoSdBBNjrnmPnwcnA8KYYwwlseA8DM=; b=jjK1U5fZrfjKdls6Mhs8UukvL0ZZ3kn27MxTL5FkZob18sH4XTOX7wrOTs5FpSE+1P 8J/FU1PAv490vVQdn7+t8TvuU8vYilFa+MMVBXzGJJIUxK76xtGznmoG3LC0t1h8B3k6 tojzYOsvf1IEBU19fsY4IJHMOIVq/pgy3hh2G7ZqW4+UZeTHgKqkOTRMg1sMs+DGmofE CSft3QDov2ohJAZ5UVD/RI9BLMyGOEWQFnE+wK+boncbYqrpnUIi1Yh5E6N6kSFSKiE3 Sa4whwVhYF+qZrMfy23VZUHZqQpAFd9wsx0lBsa6weGvZlUug7zH0sOhOix3QhUrmtiu cpCA== X-Forwarded-Encrypted: i=1; AJvYcCV++c8c1Pzbg25xekX7hdpfC4vU4UN3SSDDOqUxQsC5RF7u6WFfhRxvq15MmvG5b6vEcMHTJ1AZdN+43xo=@vger.kernel.org X-Gm-Message-State: AOJu0YzI4amq3qBUi0PTaCZpH5FqUEmFQY3E4w3GLD4RDzJ3NwsxPvJK 4XnYB6pPM+rULnOCupYXYx16NrpJeL1rcpC8wNpAZQ3SAyiaCrCmD8Rj X-Gm-Gg: ASbGnctFNaXnJtH6vYkiyYdPahaBiHgjLuwii+JfnpkYPY2yogosZ7KIn+CGpMzgoQj dSIAS9U11L72wr012TDv0NyZjTczzMQn0Vv3HA3v0WtLcN1XRdar5rE1S23S7Fo1m1z204S7DyS iGCqTrJNpoXbWKEzgA5zvGWyOTkLVVHUs1BWYrzcCQjt6wpDysI0It5Uxx2pvZyUbcYTJGSuxYC ubXks1VAiABpyVxeoBEIJRzvw7o7m0UEGvtrY7TOS6NkjRcqztMpjdVOqhcUWJJw9kCnrwdXzWN diQo3xeUkKINBJa0Fj+Vr+7Jphpscrbl/8TtajhtFP3a261wq0iu7QYvod17j9et9+yXZTRnQeo FKQR6VmLcEBXP2hh44iUSjAx/6ECllqxSGl7srkV/j+4IplS3HeIB2B1LOzgkITw/2XfkBNydPK aIQDGOEKrl0zAXV5rXa41U9AViDJFbqJHTUD0ALyCzM5NGDjIEjlsKvjDNM5pnAveGlHaIonqj7 yX4n7vGNXnNQwqq2PAUDfjTrdlHQvwGudXiiUHTbzCQw0TkDDDtJQ== X-Google-Smtp-Source: AGHT+IGndWDGT5HBliHvvDFv4NQx9Bbzbq0XpndoX+T3gaMba8GuY5uinGj6dd13eZ/B4GK6wFih8A== X-Received: by 2002:a05:6000:220e:b0:42b:3dbe:3a54 with SMTP id ffacd0b85a97d-42cc1cbd338mr8843589f8f.17.1763917170693; Sun, 23 Nov 2025 08:59:30 -0800 (PST) Received: from ?IPV6:2003:ea:8f07:a200:c9b4:617e:3ddf:6f40? (p200300ea8f07a200c9b4617e3ddf6f40.dip0.t-ipconnect.de. [2003:ea:8f07:a200:c9b4:617e:3ddf:6f40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa3592sm22441405f8f.21.2025.11.23.08.59.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Nov 2025 08:59:29 -0800 (PST) Message-ID: <107ae398-4351-4be3-83ec-d03fa91e2a81@gmail.com> Date: Sun, 23 Nov 2025 17:59:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] r8169: add support for RTL8127ATF To: Michael Zimmermann Cc: Fabio Baltieri , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251120195055.3127-1-fabio.baltieri@gmail.com> Content-Language: en-US From: Heiner Kallweit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/23/2025 5:26 PM, Michael Zimmermann wrote: >> + }, { >> + PHY_ID_MATCH_EXACT(0x001ccbff), >> + .name = "Realtek SFP PHY Mode", >> + .flags = PHY_IS_INTERNAL, >> + .probe = rtl822x_probe, >> + .get_features = rtlgen_sfp_get_features, >> + .config_aneg = rtlgen_sfp_config_aneg, >> + .read_status = rtl822x_read_status, >> + .suspend = genphy_suspend, >> + .resume = rtlgen_resume, >> + .read_page = rtl821x_read_page, >> + .write_page = rtl821x_write_page, >> + .read_mmd = rtl822x_read_mmd, >> + .write_mmd = rtl822x_write_mmd, > > I didn't get a chance to test your patch, yet, but is this intended to > match RTL8127AF? Because that's not it's phy id. It's the same as > RTL_8261C and currently matches "Realtek Internal NBASE-T PHY": > See earlier in the patch: + /* Return dummy MII_PHYSID2 in SFP mode to match SFP PHY driver */ + if (tp->sfp_mode && reg == (OCP_STD_PHY_BASE + 2 * MII_PHYSID2)) + return 0xcbff; The PHY_ID read is intercepted. > # cat /proc/self/net/r8127/enp8s0/debug/eth_phy > > Dump Ethernet PHY > > Offset Value > ------ ----- > > ####################page 0################## > > 0x00: 0040 798d 001c c890 1c01 0000 0064 2001 > 0x08: 0000 0000 0000 0000 0000 0000 0000 2000 > ####################extra reg################## > > 0xa400: 0040 798d 001c c890 1c01 0000 0064 2001 > 0xa410: 0000 0000 0000 > 0xa434: 0a0c > 0xa5d0: 0000 0000 0001 4000 > 0xa61a: 0400 > 0xa6d0: 0000 0000 0000