From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E21A232D0D8 for ; Tue, 6 Jan 2026 14:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710841; cv=none; b=fda4dSDh8GsREssDCJ7PfZja5JvmEZ1CmGQiUfYPsByLEoHhU4HV2LuI9UuZyV7bITEbvipOQ24TTrhRd7qf613YUZaPJszjVjKW4CPbe0nyWMFVYOAOkZvtgd2k785EyhB7q0Qe5EdHY1tj3YosvuTwy3B76d8OgUM3vNnhI4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710841; c=relaxed/simple; bh=1BLBAQMk8pTE3hF64+V13g2KSdCDa8b+lx+TiAfkmfg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qmn9B+fRBkzY1gbGlvT7ym9n7RsHglj7T3gBhCvko6RW7xv3o6nwcdDpUp5HGsO1y7O0Q6G+c08uJ+x5vuO0kxGJkVKBbuub0pFoM6RiQEPa8TH2UMWCNo2eklQjp7gY7MfjP9AgBMNR2hO2S6LCkASZsRvQdUZVgmojkDIFKa0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bAr0MDmy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d6dLLUxk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bAr0MDmy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d6dLLUxk" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606CAL5C4049028 for ; Tue, 6 Jan 2026 14:47:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zcfsFS04VN0Soi3THqaIkbsPmr9ODp+iS17uQAxtAY8=; b=bAr0MDmyIkL6yg9w SUhQGeEyloBC+6OLCP+Q9x2cmKDih9Qt2O+RNLsXi+P/5JNviDJTAJAmyG+UW7XS 8Yc9YKoxhy4wpIJ5o0PBYb+uOceiEHUa/iLd1hDEn0c6mNCIaDsRp0XX0BTVd0h7 bJ5XZVpd8fyWllMfnz82uX03oAnq5b4xGClzIF52jRziejYayiPJX/yrdy5nY3j7 7YAnA53HsbgyrLtRNLH+60i6G8UNG4ra7KGvPOw1SJdMS4Xqf7j56B6L3mManify wn7cZTudXPInisJ96H0WIkOlaMzv059RiOyYygntr9ulFgv5habNGxs522wp3IMj UkSAyg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bh25rre0u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 14:47:19 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0d058fc56so17796435ad.3 for ; Tue, 06 Jan 2026 06:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767710838; x=1768315638; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zcfsFS04VN0Soi3THqaIkbsPmr9ODp+iS17uQAxtAY8=; b=d6dLLUxkXJ6kY0M/MCiQIRn2/WaW/HxBjUiRqQJp4DHicbr99w5Z4g1wyzHXBWRtWX t6i499brNVyFS9gW8fE3tAJ2LGCbyzWDY2fNJR4yybu6hWEPK6MbngY0bV2RCc+NQMit LCn0p1gP3X8TwRlFHWrfUEw1qQxPOQdjJzXAOvKyPCGnow8EJTSlwqNwO3x6euH8dyyn C89xS64P51kTFG0IYLTBOeR6ajn4L6eZiATW/YFGXXWHMo0iky9qVwet1r1ZYZNdxswA HJKRcnDMGdxMlIFqiKYK2ByLMcacmgEXolFb3J9pwprEC5xPaXme/vRiXm3x0Y6Ih/Eu WTGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767710838; x=1768315638; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zcfsFS04VN0Soi3THqaIkbsPmr9ODp+iS17uQAxtAY8=; b=q1ElDvN8wkeb3pl06BVCCKQK4nJ+QWvvVJHmbGp9o07yOMBlPWTTaFP7oP/QfSE78w Sq73fQEzG9t6rk1R1yLH03nSCumEnER+Gx2AXwYFNOEiyk9FCurzgATuwWoO76fRnbNW 8TZ4F2XGTmK4iG8oqtBZfTugWiTSew6Rh6VXO12+vSvOuEqIs5R3e8ghq9EAvJZTxNO6 QP73cRac6PxfZ5poWuphzTwc3QsaYJpLHunmZSLxWzQSPHgnG8UWw1+Mn+cWzIPcHqz4 DZVc6K9Iev56Livx7kT9vZdAtTcf7wnfPuH3asvi+KCtdAxjF1AoWB1+ot9klkTKGDlA jdew== X-Forwarded-Encrypted: i=1; AJvYcCXf7N5BKZ7f+TqA1aUC9LLmo9fOmw54Sr7FTpLZHzzRK+wl8KxI4KOAknf8ITCbKEbjt82suWi9tgShAaw=@vger.kernel.org X-Gm-Message-State: AOJu0YxSq/okDPjtd5WG0ol9cuhons3IJSnDs9svLMMZr/YnF+EVTOzf Fqlk/hepA1gWHNmCWTSFn5aE/1VHCRhakaDDWA7pnKglcPF4q1/ZLiyFQC9P2fROlLYS6olI62k 5s4/b/9jR/6yg7/DAFF/rOrlkaOcgS+Bs5RvRO11tMOlJkXEnk1iUEo6bojuU+6Fnq2M= X-Gm-Gg: AY/fxX5izloNvDWHlOG4CFLWSybWicOztrQ3m1njV0Bg7rYi7Ek8F5G8bjopqlI7SLr imoUVQihzZXl0W597S20MN/0o2WCPuSmQ+IXCbTgsJ+hKK74duoR3KOhd088Nw2CV/Gf3tFvmnd Zfhwvwd/MPGv//1G9q+9sjTEasr/lq3dbkCn/5w/bVo8MGdNawDqcQXKrgzCX/dj0Ui8JI7Fw0r fd0hRW3/wZXtgB9y/YWwGGspyazEOx8B7IF1gCdBqTZwp+qwcV3HFvtaiCLlJbnoGtWgpiIEgBw 29WIcFlAaiJY+YGphN0N0/hdHwaluHIgvRFMvgpWyQyj0c/nyTIIRP4cwMSbgkrtktiCN8bP2vp KoaRSIDpEWoFvZmYiYrX3zFHDm2Klr7FL2AzLz1pZ6+E= X-Received: by 2002:a17:90b:4f88:b0:32e:5646:d448 with SMTP id 98e67ed59e1d1-34f5f30038bmr2743060a91.21.1767710838388; Tue, 06 Jan 2026 06:47:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNSDUxkQhO/yV3l5ELdMmGOkQbRz1mErp+pZNgrdUbiWyRnlViktR5bVwFxL5b/wwflX2M1A== X-Received: by 2002:a17:90b:4f88:b0:32e:5646:d448 with SMTP id 98e67ed59e1d1-34f5f30038bmr2743028a91.21.1767710837911; Tue, 06 Jan 2026 06:47:17 -0800 (PST) Received: from [10.216.40.68] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cc8d29521sm2634999a12.23.2026.01.06.06.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 06:47:17 -0800 (PST) Message-ID: <107b43ab-85fe-8b09-a622-854f9672f45f@oss.qualcomm.com> Date: Tue, 6 Jan 2026 20:17:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v19 01/10] power: reset: reboot-mode: Remove devres based allocations Content-Language: en-US To: Bartosz Golaszewski Cc: Dmitry Baryshkov , Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Andy Yan , John Stultz , Matthias Brugger , Moritz Fischer , Mark Rutland , Conor Dooley , Konrad Dybcio , Florian Fainelli , Krzysztof Kozlowski , Mukesh Ojha , Andre Draszik , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla References: <20251228-arm-psci-system_reset2-vendor-reboots-v19-0-ebb956053098@oss.qualcomm.com> <20251228-arm-psci-system_reset2-vendor-reboots-v19-1-ebb956053098@oss.qualcomm.com> From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 0H-HJF-lpIWdJZYIbJ2jZyOA8mCZEJHM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDEyOCBTYWx0ZWRfXy7j0sPEgUhFe CmUagGr9ndLS8xTaolxCYYYM0aoMYK6n+Qcf6LQSK/ZDbkWyvstq3vqxSdzm8pkf4nBy1Rl76HW 4enYk7w16VUr4BoIyECZDmlEQYa6KoG2oMULwu5GliilCxkrFCY2NUg81HP1x3sAP5eCBerUpsB hvx0jJpSV/jX+DXB4k2QexKUz0mnkWwuYqudGrABNaEirjgyQ8hCofjQ3wEbJdx/kIkj0J98Ke4 /Zy9fgNDMFlBMQAMJl5qaJSbic3nlX9rXQ0UPAWE77JKfykB698E3/lVLwsrXVa+/qBPlNu4xtq sCgOTMayCBZkXrMIR1Jj6yB7toCSddlFh+oXc0V21bshnlHXnP3LKUfHfkAR59iMPRJAm2b4LRf V3QwAkRRWkM18yTuYx15+eff/baD1qs+vFBayZW/XcmtP85pX1puHuGOyZAlMqWY377OOX66MBJ dY13xEP3rrlCx4vQ6aA== X-Proofpoint-ORIG-GUID: 0H-HJF-lpIWdJZYIbJ2jZyOA8mCZEJHM X-Authority-Analysis: v=2.4 cv=G48R0tk5 c=1 sm=1 tr=0 ts=695d2077 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=uBB1BXs7VCbqA7mTJTUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060128 On 1/6/2026 6:00 PM, Bartosz Golaszewski wrote: > On Tue, Jan 6, 2026 at 7:31 AM Shivendra Pratap > wrote: >> >> >> >> On 1/6/2026 3:01 AM, Dmitry Baryshkov wrote: >>> On Mon, Jan 05, 2026 at 11:46:40PM +0530, Shivendra Pratap wrote: >>>> >>>> >>>> On 1/2/2026 3:35 PM, Bartosz Golaszewski wrote: >>>>> On Sun, Dec 28, 2025 at 6:20 PM Shivendra Pratap >>>>> wrote: >>>> >>>> [snip] >>>> >>>>> >>>>>> + pr_err("reboot mode %s without magic number\n", prop->name); >>>>> >>>>> If this is an error, shouldn't we bail out? >>>>> >>>>>> + continue; >>>> >>>> This is not an error as per original design of reboot-mode framework. >>>> The code as of now says, if the reboot-mode node has an entry without >>>> proper magic value, ignore it, and, process the next. >>> >>> Then why are you using error level for the message printout? >> >> I have changed from dev_err to pr_err. Can make it pr_info. Will >> that change need a mention in commit text? >> > > If we can ignore something safely, then I'd just use pr_debug(). Ack. thanks, Shivendra