From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757849AbcH3Swn (ORCPT ); Tue, 30 Aug 2016 14:52:43 -0400 Received: from mail-he1eur01on0068.outbound.protection.outlook.com ([104.47.0.68]:3216 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750809AbcH3Swi (ORCPT ); Tue, 30 Aug 2016 14:52:38 -0400 X-Greylist: delayed 4575 seconds by postgrey-1.27 at vger.kernel.org; Tue, 30 Aug 2016 14:52:37 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH v14 04/14] task_isolation: add initial support To: Frederic Weisbecker References: <1470774596-17341-1-git-send-email-cmetcalf@mellanox.com> <1470774596-17341-5-git-send-email-cmetcalf@mellanox.com> <20160811181132.GD4214@lerouge> <20160830005550.GB32720@lerouge> <69cbe2bd-3d39-b3ae-2ebc-6399125fc782@mellanox.com> <20160830171003.GA14200@lerouge> CC: Christoph Lameter , Gilad Ben Yossef , Steven Rostedt , Ingo Molnar , "Peter Zijlstra" , Andrew Morton , Rik van Riel , Tejun Heo , Thomas Gleixner , "Paul E. McKenney" , Viresh Kumar , Catalin Marinas , Will Deacon , Andy Lutomirski , Michal Hocko , , , , From: Chris Metcalf Message-ID: <107bd666-dbcf-7fa5-ff9c-f79358899712@mellanox.com> Date: Tue, 30 Aug 2016 14:17:27 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BY2PR06CA045.namprd06.prod.outlook.com (10.141.250.163) To VI1PR0501MB2767.eurprd05.prod.outlook.com (10.172.11.17) X-MS-Office365-Filtering-Correlation-Id: 3a1da15b-ae8d-4e3d-f446-08d3d101f4b7 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2767;2:K8H1UrsveS5wvwt0gABRxQBjEcfOS71KoeuyrKlWFDkvKpgI/S+AwDF0DyELaZvuAXTu8g8uS6BCDlmmCJ+B3Rva9jGNFgk0R/Waeeayv95yMT9oKse9rD/ocvn5OKeyw5PGTCG/XBpeGzr1EmCLQMbBEv4mUSJfmIHhdSv7I/+agFkYUmpW7rBKoGHdl3Gt;3:pp+vbImWjEP91yEZM18X0T/9K8HVZ3MUTnwRHgOGIVJDEtImCWavst40AHT/kkf5Wp7UhfyuYc5cX6NgwfiXco6ObGQPeWmxPrY6zON3/n4nzHd3Lw4n/02XD0Lr181Q X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0501MB2767; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2767;25:XI00Lu0PfNK+suasklsDaux+0EgHYtD56QtoVHHqgmNADhN8/10rUnzTCfOOu6gdHngUNI2BgXmLtKP5AAZ7nddkITdbTW1BGukzyOB6gAx5+TXuDFlgkj/rOjv2sgN5Gf7evu64LhfeD04uk88a7oQxfawMt9RrQCA8jk2h1kLZTxs2S9SZ1UmhuwZm1QfDGZKAJYNPH5vbPxh0W530sQXRA+s4ejLeSjMwhkrc4a2LWJxehq1f3VncIUDmQB3Lqqm3oYrW1skqxnwdVanddubIeucUmEh64ri1Jo/es6O1moXD/9n51kJgucWZqawI27GTk8OyM5xMya4H0DH3byI/xy3PzVGSyaySZ8aPQjUX74YrBeY0L+55Na/wByfgJcL66TH6K0tNjOnA94qOUF7vjCHZjdCET9bDZzGd+iTg8ojKaGejCB8c4qu1qnXnFXbNHjyURB3VpYXLWDTRv86sq1FuDrIp2jKQTxAHj+Knu0IU/JPA7+Ce/AL+Sq5eoAipcoIAkSk5FrfRp44rnIgTVfWELSKnbpzWAWmHD/OR3pmDcHe4H5d4Mz5l8lqvf2HKbIIkoSfMh6xdJHS81nzp4qxDO2QD6w86moVBzHcFXmPcTUe4+ha+ZCF/PX1tEA0fL2GOWEh1Gw1LgrKcENvcMdp0WmdnSMWGXqjJVVRuZm2r+kv+h3yhVBlxxj3i4ch81oa9D/94oVWVElxIk+I6nMLCRkI7g2g3yq1Uz3r4ME3ufQaAF89K7qJsDffjX+Obg1MdHOJbkDtC5q0eHOb9jB0X/lVvNcxwMeOR/yru+JIgE2KUUW+dz7E3y+SqhCFqqjzGK/k31SYCWnbdAA== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2767;31:wfZCQYF8n9sRim9pim8RH4iqHKzca8nV3wviHlz9+Si8OVpn7gigu57jGZUijUsqVTbUhMH9KIewdVmPOpu0G6xDsC25JMXeT70vF6RvY+RJqnneH1vdbKdhjdld580L+tCyvY7dSDq/ko/PALr7zYKEFnQ8/nFQsE0rbtQoHPNsnAJiei1QS8w/SWzVG++hAWwq5Fmbbqo77bz5Q2EUqk66kHpXvyXbEk9+8ufbjgw=;20:F7sJp+I/8UMiW0Yj0bFloO8pMstMFaal3GaYUD7js6CTW78g2MEK9mk61/+nPQVH7Ah6cJiJejaZD925TyQoENqBFERGcC7+vE8EcbwNfeNbKqRrcaCaTfGrFiWeTa7BXPCMekm7grhNXib6ifYcO/Ij71KL98AqSxLZkZiOguyTu6SLT/Dn+Tmye0qxlDwKGOu1GfsA0MZlYqFBobCeYo+Fc7UgLtbJEEYU/jhdZCj9G8RGShH3hT9zu9G9wY30tIhLnopv37upRp4otJbv/adZEuzWjnsKIKnp+GtquZnwhV2uNe+QB5lKkGMREkQzvgJmeM0uuc0yTTLH3ysGA4uuZ9ca3/l/v/nqymfzeZEO3Om7zM8xRrfsn92qXItUf1JHLdMXopVKnH6yvgARuJlFuY6E/Rli+zooJn4mhfaFAqvVr40OPuXjcw9pkOM4zWNHu9jYuV7WShxnJ9nIcis0SOc9dL9YU+VCK+gotedO9fdrdweoFka28VBE+PBk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:VI1PR0501MB2767;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0501MB2767; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2767;4:gvO62pq/nITt5MMtO8JKmZ+U3OSfP4DFHcPp+BEPZV5gbR0BFJvc1fC5gQ3EKrc0FJyha0Z79gGCCOlNrW/efnXCcITvF/kJkD5Q4CXHd60rBChCtZQSPa83rBycwyibjSazu8lV/1L+5RDTBRGqgxq7srqTOrmo769bFGSc6F0eL+zrFqUjBUft73bQQ8Lqvn9U0hD6ql++/ZBpdOIrRg+d1m7++C6eIM8ml3M7hFaeRvUqH++aQ1zDF3WeyInxqrOvJTsGtiG1niG0yGfxMU2ZVgvLon/rGTYr0fMvOWLfgMY9Qu61QogGJCAtAcD+ZynAvVsq+OLWB7wR+NMPqzuZsjI/A+9m1x9Cg0KQQzd4LmsIeicgjQbwWylVKPlw+E0c2jMtNS63YFIxAPwXMxEigbZtQ6Ez27r94ohKU/HhYmvHX2AwyM1eq0DK1wX0 X-Forefront-PRVS: 0050CEFE70 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(199003)(52314003)(189002)(24454002)(377454003)(101416001)(7846002)(230700001)(31686004)(33646002)(7736002)(47776003)(305945005)(106356001)(92566002)(7416002)(189998001)(68736007)(5660300001)(50466002)(586003)(76176999)(77096005)(105586002)(66066001)(42186005)(15975445007)(2906002)(81156014)(81166006)(2950100001)(19580395003)(1411001)(83506001)(3846002)(4001350100001)(86362001)(110136002)(31696002)(23746002)(65956001)(65826007)(6116002)(4326007)(65806001)(54356999)(64126003)(97736004)(36756003)(93886004)(50986999)(8676002)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2767;H:[10.15.6.55];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0501MB2767;23:mL5lusBk3UA4meks/La85py1A2O3jrCWY99?= =?Windows-1252?Q?tQ91h5j/18ZyaxDpGpwpSEW2SjWFvUSqaALg50W5NuPwmWIog3TqQM/L?= =?Windows-1252?Q?0y158HWZweyXdw4Z3Uw5HayijuzPv4KN4oXWUxx0Ut0uhduj8qq8uL5V?= =?Windows-1252?Q?R8GscEL0Y/kcJ/gY4qXZKOowiXnMGs4BSd9R03Vejx68f3wjvHUkZu4N?= =?Windows-1252?Q?K8Sj3xWHvB55IsgD+m7F17xhJwUQILKr3cpBDvTDfrjkB4X+iU/VEuLi?= =?Windows-1252?Q?vG+RDGCuOLqd7UgAlyhtUrpzhTqz7cVtymO+OfW9GiYwlwRK45TynNE1?= =?Windows-1252?Q?aokI5pk/aHMacsU0aylDmsTu+LIrUYvqMoj1cmPglu/cn64OnfuV2N97?= =?Windows-1252?Q?D4sU4vEjsNw42KxIRplUXFruIChO4LeYIKauXKAoUsiSiefGg3be6LU2?= =?Windows-1252?Q?OHBveWs7q5qliHhWctSnklkNq48e4qKEFx25qYv9WbLOwScgK4wAgLAq?= =?Windows-1252?Q?KuTKvFq6F5hJkafvMKMEHXpymHAc130/PUIBRWnExcW+XHHpzxmBbhiL?= =?Windows-1252?Q?Jy/F5f5SsD3sEa053fZ6HtFtZGq0vbw1d00+MWn2bjgQbXhPnp3HHFVA?= =?Windows-1252?Q?sKSHupfgXb10uQRhomc1Yanw1RrlWxPCPISkxRPWLO5GHpV7E3MZ3bAQ?= =?Windows-1252?Q?tfmdVPNYNmkz9laRFQhIzvD7g6R7zxCK9o03P005Uhqa6qUQUnXuw+Mw?= =?Windows-1252?Q?XNiMwWmjOiDs2mk6lmxQsozBjpZKEHuuA/reXukbePPq1rAzux6x92sH?= =?Windows-1252?Q?giDRGm4MGNfN86SzGXgPHFUh3CkeAQs/IizD8WYvTRr+43Mte77EY5IT?= =?Windows-1252?Q?ZUHVxxvI8SLpJA2ttfveDwXRZpMACgVaWYPnhGRWrHVA/NiY/edF9fla?= =?Windows-1252?Q?cO2SQjd3sBBosW5E/7I3BYgHxR+Gz6kAYf4QLD2N3zF5UKd+YUAAv8yv?= =?Windows-1252?Q?Ohl9z0WSTyXf8GhWSEG+10pL4CSwNnvMuPrdCeh7sbVhSKa2GHTgxGUP?= =?Windows-1252?Q?Yxlp4ExxxHI8FoQYqNvI5y0rZbdots0LwgoTyZsgH9+dSDnvf9gG3oPu?= =?Windows-1252?Q?8tzUSJ7wzpxgsRUduIWb7ItWrfL/QOHyqOzjZk/rNPDk+oCeOANAah7K?= =?Windows-1252?Q?l1O05FL6GEla1QJtRwR2dqQ/GkkG4EGG68Js25+A4JUFVZBbtY78dkEc?= =?Windows-1252?Q?+raxREepQoUPxMpM4HvekoLYp26b8G7Sn4C5hxrqkjjQCAhgU+lB2qhQ?= =?Windows-1252?Q?YYpXN/CMGklTvOKURQy/DcxdrDXAyK97RediRFL7b3FpSpToTUGV0qsq?= =?Windows-1252?Q?Gjgz63TfL1AuK98C1FOI90zALJ4wiURRzMGypy87EFaeJhjL7DUwn7p6?= =?Windows-1252?Q?840UDq0HDxzkx2ME38O9GUkpD0B+kBKW7jrdQndakMxRgppbayegQm0G?= =?Windows-1252?Q?rhEJZzuYykos5UI3UXgBXHjb42zPn?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB2767;6:DxAd5C8Z89MLgM8dScuhziXV5YTgbM+47tP47FYfHZg5uYfbYRN0ulwh9qsHysqa/e8DUJ89vQydXEkihQPy0QcCzKav4MjTajQ1P9BqItypqFKo/mSxGh6QBFiGlqmjXO6HNxykrnueh9F9IklYCMCkldOvFM9JecEVsr4o0KQsMgvvisAfmUW4sjLuHpOd+QIYBlPJcYK+vHaQ2rqgFSrtx9+msIh3PfiyIIibIusGDbXf2mfwyIHPsiUDpCerZvFXUzbKzT3cBB300KY8bf9reBYdZIL1noNEoVCsAn9kyRZLd8P9iCZiJMUP+G4sb5GkSASRMyhXKv7GC3CCcg==;5:iPsNSW3WPLrxMS3JoqTCXQVFZtgwMWHWjZdaE9I5OIaOHOJqd7oSZdkZk++vP1vDKQvcCVGSnwQVqXiyuyfJu8pbp944eIzmLrxjT1eQqjDFtwN/xluNg5eYvWn/Xi97z+EwEfRuqjAoUOOID1e5hw==;24:nHGrMXAcZBnQghhC/LV8Ph0T6hi3Q2BktEUK5rNzyLMWwJ6EEcQeYjb88llA/xKPiBNsOfzrSVHFvY1pMlt6aBy/NshWYX8FTHY1dICr+YQ=;7:ylQB+7zLAASK3OMxb51Xc0w75PqHh5vGguwCCYjEIDJTLtN7lMe2jGWCQwMshDjvWdgqiw0+c6J0KEa1Vv0MnKLqVkblXLUkm84WtIkizt1qADkIS/FdHFP951hhSpIedjxGXhwqcZja5ZdqsKOwTH93YoEW3scoelfpzCstmgnXEM3l0EXhvbQoggic7VXmKfKvKaQnfXrQc2WaPjbjiDx7yc1/5LUnZC7hsvJoeje9Pnv+lBS1MNqUm9nlyLcA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2016 18:17:41.8625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2767 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/2016 1:36 PM, Chris Metcalf wrote: >>> See the other thread with Peter Z for the longer discussion of this. >>> At this point I'm leaning towards replacing the set_tsk_need_resched() with >>> >>> set_current_state(TASK_INTERRUPTIBLE); >>> schedule(); >>> __set_current_state(TASK_RUNNING); >> I don't see how that helps. What will wake the thread up except a signal? > > The answer is that the scheduler will keep bringing us back to this > point (either after running another runnable task if there is one, > or else just returning to this point immediately without doing a > context switch), and we will then go around the "prepare exit to > userspace" loop and perhaps discover that enough time has gone > by that the last dyntick interrupt has triggered and the kernel has > quiesced the dynticks. At that point we stop calling schedule() > over and over and can return normally to userspace. Oops, you're right that if I set TASK_INTERRUPTIBLE, then if I call schedule(), I never get control back. So I don't want to do that. I suppose I could do a schedule_timeout() here instead and try to figure out how long to wait for the next dyntick. But since we don't expect anything else running on the core anyway, it seems like we are probably working too hard at this point. I don't think it's worth it just to go into the idle task and (possibly) save some power for a few microseconds. The more I think about this, the more I think I am micro-optimizing by trying to poke the scheduler prior to some external thing setting need_resched, so I think the thing to do here is in fact, nothing. I won't worry about rescheduling but will just continue going around the prepare-exit-to-userspace loop until the last dyn tick fires. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com