From: Arjan van de Ven <arjanv@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "Bagalkote, Sreenivas" <sreenib@lsil.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH][RELEASE] megaraid 2.10.2 Driver
Date: Tue, 23 Mar 2004 09:12:36 +0100 [thread overview]
Message-ID: <1080029556.5296.2.camel@laptop.fenrus.com> (raw)
In-Reply-To: <405F71CB.7000902@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On Tue, 2004-03-23 at 00:07, Jeff Garzik wrote:
> Bagalkote, Sreenivas wrote:
> > Hello,
> > @@ -45,6 +46,10 @@
> >
> > #include "megaraid2.h"
> >
> > +#ifdef LSI_CONFIG_COMPAT
> > +#include <asm/ioctl32.h>
> > +#endif
> > +
>
> For upstream, this should just be CONFIG_COMPAT I presume.
well we should fix all arch's to provide a dummy header I guess so that
we don't need fugly ifdefs.
> >
> > +#ifdef LSI_CONFIG_COMPAT
> > + /*
> > + * Register the 32-bit ioctl conversion
> > + */
> > + register_ioctl32_conversion(MEGAIOCCMD,
> > megadev_compat_ioctl);
> > +#endif
> > +
>
> ditto
ditto about providing a stub register_ioctl32_conversion().
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-03-23 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 22:56 Bagalkote, Sreenivas
2004-03-22 23:07 ` Jeff Garzik
2004-03-23 8:12 ` Arjan van de Ven [this message]
2004-03-23 0:02 Bagalkote, Sreenivas
2004-03-23 0:45 ` Matthew Wilcox
2004-03-23 6:27 ` Christoph Hellwig
2004-03-23 13:30 ` Matthew Wilcox
2004-03-23 13:36 ` Christoph Hellwig
[not found] ` <20040324061553.GA13681@logos.cnet>
2004-03-24 20:39 ` Marcelo Tosatti
2004-04-17 2:15 ` Jeff Garzik
2004-03-23 16:00 Bagalkote, Sreenivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1080029556.5296.2.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome