From: Christophe Saout <christophe@saout.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Jens Axboe <axboe@suse.de>, nagyz@nefty.hu, linux-kernel@vger.kernel.org
Subject: Re: pdflush and dm-crypt
Date: Tue, 30 Mar 2004 11:46:11 +0200 [thread overview]
Message-ID: <1080639971.7152.7.camel@leto.cs.pocnet.net> (raw)
In-Reply-To: <20040329161248.41e87929.akpm@osdl.org>
Am Mo, den 29.03.2004, um 16:12 Uhr -0800, schrieb Andrew Morton:
> How come? Isn't this problem just "gee, we have a lot of stuff to encrypt
> during writeback"? If so, then it should be sufficient to poke a hole in
> the encryption loop?
>
> --- 25/drivers/md/dm-crypt.c~a Mon Mar 29 16:11:49 2004
> +++ 25-akpm/drivers/md/dm-crypt.c Mon Mar 29 16:11:56 2004
> @@ -669,6 +669,7 @@ static int crypt_map(struct dm_target *t
> /* out of memory -> run queues */
> if (remaining)
> blk_congestion_wait(bio_data_dir(clone), HZ/100);
> + cond_resched();
> }
>
> /* drop reference, clones could have returned before we reach this */
cryptoapi always does this after every block. It also happens with
preemption enabled. I got feedback from a person who said that renicing
pdflush to 0 helped. So it looks like the CPU scheduler doesn't want to
schedule pdflush away. Hmm.
next prev parent reply other threads:[~2004-03-30 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 14:50 Zoltan NAGY
2004-03-29 15:01 ` Jens Axboe
2004-03-30 0:12 ` Andrew Morton
2004-03-30 6:22 ` Jens Axboe
2004-03-30 9:46 ` Christophe Saout [this message]
2004-03-30 10:07 ` Andrew Morton
2004-03-30 11:59 ` Zoltan NAGY
2004-03-29 15:01 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1080639971.7152.7.camel@leto.cs.pocnet.net \
--to=christophe@saout.de \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nagyz@nefty.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®