Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Axelera Embedded 111c

[Heiko Stuebner <heiko@sntech.de>]

Am Dienstag, 20. Oktober 2026, 13:37:17 Mitteleuropäische Normalzeit schrieb Patrick Barsanti:
> Add minimal device tree for the Axelera Embedded 111c
> (rk3588-embedded-111c).
> 
> It offers efficient AI compute for multi-stream computer vision and
> GenAI applications in a compact design. It features a quad-core
> Axelera AI Metis AIPU and an RK3588 SoC processor.
> 
> This basic version of the dts supports:
> - Console
> - eMMC
> - HDMI
> - 4x USB-A
> - 2x Gigabit Ethernet
> - RTC
> - Enumeration of on-board Axelera Metis AIPU
> 
> Link: https://axelera.ai/axelera-products/embedded/111c
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Signed-off-by: Patrick Barsanti <patrick.barsanti@amarulasolutions.com>

that Signed-off chain is not correct.

As it stands, the first signed-off would indicate Michael as the author.

If all 3 of you worked on this, this needs Co-developed-by tags, though
3 people for one devicetree?



> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-embedded-111c.dts b/arch/arm64/boot/dts/rockchip/rk3588-embedded-111c.dts
> new file mode 100644
> index 000000000000..a964b46e5c12
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-embedded-111c.dts

please name this rk3588-axelera-embedded-111c.dts

The name is otherwise way too generic.


> +			vdd_log_s0: dcdc-reg3 {
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <675000>;
> +				regulator-max-microvolt = <800000>;
> +				regulator-name = "vdd_log_s0";
> +				regulator-ramp-delay = <12500>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +					regulator-suspend-microvolt = <750000>;

regulator-suspend-microvolt is deprecated, so should not be used in
new devicetrees. Same for all other occurences.


rest looks ok :-)


Thanks
Heiko