mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Anton Blanchard <anton@samba.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ppc64: create dma_mapping_error
Date: 02 Apr 2004 11:33:34 -0500	[thread overview]
Message-ID: <1080923616.1829.73.camel@mulgrave> (raw)

What exactly are you guys doing?

The API Anton introduced:  dma_mapping_error() takes only a virtual
address as the argument (no struct device or anyting), so the additional
API's pci_dma_mapping_error() and vio_dma_mapping_error have absolutely
no choice but to do the same thing as dma_mapping_error() (because the
error return cannot be bus or device specific).

So, why bother introducing all these superfluous APIs in the first
place?  Just stick to the single dma_mapping_error(); it will be much
easier.

James



             reply	other threads:[~2004-04-02 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-02 16:33 James Bottomley [this message]
2004-04-07 14:30 ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1080923616.1829.73.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®