From: Xavier Bestel <xavier.bestel@free.fr>
To: Andi Kleen <ak@muc.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, linux-kernel@vger.kernel.org
Subject: Re: {put,get}_user() side effects
Date: Tue, 06 Apr 2004 13:50:29 +0200 [thread overview]
Message-ID: <1081252228.8318.1.camel@speedy.priv.grenoble.com> (raw)
In-Reply-To: <m3fzbhfijh.fsf@averell.firstfloor.org>
On Tue, 2004-04-06 at 13:32 +0200, Andi Kleen wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>
> > On most (all?) architectures {get,put}_user() has side effects:
> >
> > #define put_user(x,ptr) \
> > __put_user_check((__typeof__(*(ptr)))(x),(ptr),sizeof(*(ptr)))
>
> Neither typeof not sizeof are supposed to have side effects. If your
> compiler generates them that's a compiler bug.
Using ptr three times in a define has side effects if ptr is an
expression with side effects (e.g. "p++").
Xav
next prev parent reply other threads:[~2004-04-06 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1HVGV-1Wl-21@gated-at.bofh.it>
2004-04-06 11:32 ` Andi Kleen
2004-04-06 11:46 ` Geert Uytterhoeven
2004-04-06 20:53 ` Horst von Brand
2004-04-06 22:53 ` Andreas Schwab
2004-04-06 11:50 ` Xavier Bestel [this message]
2004-04-06 12:17 ` Wichert Akkerman
2004-04-06 14:28 ` Xavier Bestel
2004-04-06 15:30 ` Kevin P. Fleming
2004-04-06 15:47 ` Xavier Bestel
2004-04-06 10:03 Geert Uytterhoeven
2004-04-06 10:10 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1081252228.8318.1.camel@speedy.priv.grenoble.com \
--to=xavier.bestel@free.fr \
--cc=ak@muc.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®