From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, linux-kernel@vger.kernel.org,
uclinux-dev@uclinux.org
Subject: Re: [PATCH 1/2] NOMMU: Set BDI capabilities for /dev/mem and /dev/kmem
Date: Tue, 29 Aug 2006 19:39:54 +0100 [thread overview]
Message-ID: <1082.1156876794@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060829112030.a2a8c763.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
> #else
> #define get_unmapped_area_mem NULL
> #endif
Blech.
Of course, I could just declare the new symbols weak, and stick
get_unmapped_area_mem() and mem_bdi in their own file which would be
conditional on !CONFIG_MMU.
> This changes behaviour, doesn't it?
Yes.
> But only for !CONFIG_MMU kernels?
Yes. For the moment, nothing in MMU world actually looks at these
capabilities, though perhaps they should.
> Perhaps some additional commentary around this is needed.
Perhaps... or perhaps it should have different capabilities if there's an MMU.
Is doing a private mapping of /dev/mem a valid thing to do anyway, even if
there is an MMU?
David
next prev parent reply other threads:[~2006-08-29 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 17:59 David Howells
2006-08-29 17:59 ` [PATCH 2/2] NOMMU: Check that access_process_vm() has a valid target David Howells
2006-08-29 18:20 ` [PATCH 1/2] NOMMU: Set BDI capabilities for /dev/mem and /dev/kmem Andrew Morton
2006-08-29 18:39 ` David Howells [this message]
2006-08-29 19:28 ` Andrew Morton
2006-08-30 8:38 ` David Howells
2006-08-30 15:05 ` Andrew Morton
2006-08-30 9:24 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1082.1156876794@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®