From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Fabian Frederick <Fabian.Frederick@skynet.be>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.6rc1-mm1] NFS sysctlized - readahead tunable
Date: Mon, 19 Apr 2004 17:08:27 -0400 [thread overview]
Message-ID: <1082408907.3360.14.camel@lade.trondhjem.org> (raw)
In-Reply-To: <1082407753.18853.12.camel@bluerhyme.real3>
On Mon, 2004-04-19 at 16:49, Fabian Frederick wrote:
> Trond,
>
> Here is a patch to have nfs to sysctl although Maxreadahead is tunable
> under nfs init only.Do you have an idea and do you think it's acceptable
> to make it applicable directly i.e. would it be readahead reduction
> tolerant ?
>
> btw, is this inode.c an issue for V4 ?
>
The lockd module has already registered the name /proc/sys/fs/nfs, so
your scheme will end up corrupting the sysctl list. Sorting out the
/proc namespace issue is the main reason why this hasn't been done
before.
Personally, I'd prefer renaming the lockd module into
/proc/sys/fs/lockd, but it will have to be up to Andrew to decide
whether he wants to allow that during a stable kernel cycle.
Also note that putting initializers into a ".h" file is horrible style.
".h" files should be for forward declarations only.
Cheers,
Trond
next prev parent reply other threads:[~2004-04-19 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-19 20:49 Fabian Frederick
2004-04-19 21:08 ` Trond Myklebust [this message]
2004-04-19 21:29 ` Fabian Frederick
2004-04-20 0:01 ` Trond Myklebust
2004-04-20 6:12 ` FabianF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1082408907.3360.14.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=Fabian.Frederick@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®