mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Mason <mason@suse.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
	pbadari@us.ibm.com, linux-kernel@vger.kernel.org,
	ext2-devel@lists.sourceforge.net
Subject: Re: ext3 reservation question.
Date: Thu, 22 Apr 2004 09:43:07 -0400	[thread overview]
Message-ID: <1082641387.12989.61.camel@watt.suse.com> (raw)
In-Reply-To: <20040421204036.4e530732.akpm@osdl.org>

On Wed, 2004-04-21 at 23:40, Andrew Morton wrote:

> The code I had at the time would reserve space in the filesystem
> correspnding to the worst-case occupancy based on file offset.  When we
> actually hit ENOSPC in prepare_write(), we force writeout, which results in
> those worst-space reservations being collapsed into their _real_ space
> usage, which is much less.  So writeout reclaims space in the filesystem
> and prepare_write() can proceed.
> 
> That worked fine on ext2.  But on ext3 we have a transaction open in
> prepare_write(), and the forced writeback will cause arbitrary amounts of
> unexpected metadata to be pumped into the current transaction, causing the
> fs to explode.
> 
> At least, I _think_ that was the problem.  All is hazy.
> 
One possible solution is to allocate holes in the file during
prepare_write/commit_write, logging the metadata as you go.  Then during
each commit fill any delayed allocations.  You've still got a
potentially unbounded operation for logging the bitmaps, maybe solvable
through creative reservations.

-chris


  reply	other threads:[~2004-04-22 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-21 23:55 Badari Pulavarty
2004-04-22  1:08 ` Andrew Morton
2004-04-22  3:05 ` Linus Torvalds
2004-04-22  3:40   ` Andrew Morton
2004-04-22 13:43     ` Chris Mason [this message]
2004-04-23  5:22     ` Alex Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1082641387.12989.61.camel@watt.suse.com \
    --to=mason@suse.com \
    --cc=akpm@osdl.org \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®