From: Steve French <smfltc@us.ibm.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-kernel@vger.kernel.org, linux-cifs-client@lists.samba.org,
jra@samba.org
Subject: Re: [PATCH COW] sys_copyfile
Date: 27 Apr 2004 14:46:19 -0500 [thread overview]
Message-ID: <1083095178.4792.4.camel@stevef95.austin.ibm.com> (raw)
In-Reply-To: <20040427164220.GB2176@wohnheim.fh-wedel.de>
On Tue, 2004-04-27 at 11:42, Jörn Engel wrote:
> Shouldn't it be rather
>
> if (old_nd->dentry->d_inode->i_op->copy)
> return old_nd->dentry->d_inode->i_op->copy(old_nd->dentry,
> mode, new_dentry);
>
> or something similar? The copy() effectively replaces the complete
> create/sendfile/possibly-unlink series.
>
In some network protocols the client does not know whether the server
wants to support copy operation or not (perhaps if the files were on
different server partitions the server might return an error e.g), in
those cases the filesystem client could return error not supported or
equivalent and the remainder of your function is executed doing the copy
the harder way (open/read/close create/write/close) but still faster a
few percent faster than before your patch.
next prev parent reply other threads:[~2004-04-27 19:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 15:58 Steve French
2004-04-27 16:42 ` Jörn Engel
2004-04-27 19:46 ` Steve French [this message]
2004-04-27 19:55 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2004-04-26 9:20 Jörn Engel
2004-04-27 11:30 ` Erik Mouw
2004-04-27 11:47 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1083095178.4792.4.camel@stevef95.austin.ibm.com \
--to=smfltc@us.ibm.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=jra@samba.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®