mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Colin Paton <colin.paton@etvinteractive.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Possible permissions bug on NFSv3 kernel client
Date: Thu, 29 Apr 2004 13:39:13 -0400	[thread overview]
Message-ID: <1083260353.3686.63.camel@lade.trondhjem.org> (raw)
In-Reply-To: <1083236543.4541.293.camel@colinp>

On Thu, 2004-04-29 at 07:02, Colin Paton wrote:

> In file: fs/nfs/nfs3proc.c modify nfs3_proc_access(). This calls the
> access RPC on the server. I added the following to the code:
> 
>             if (S_ISBLK(inode->i_mode) || S_ISCHR(inode->i_mode))
>                 {
>                     // Leave arg.access untouched.
>  
>                 }
> 
> ...so that the the MODIFY and EXTEND bits aren't set when writing to a
> block or character device.

Hmm... Why shouldn't the MODIFY bit at least be set if the user
requested write access to the device?

Cheers,
  Trond

  reply	other threads:[~2004-04-29 17:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-29 11:02 Colin Paton
2004-04-29 17:39 ` Trond Myklebust [this message]
     [not found] <1QhAA-5zc-13@gated-at.bofh.it>
     [not found] ` <1QnPD-2pg-1@gated-at.bofh.it>
2004-04-29 20:49   ` Pascal Schmidt
2004-04-29 21:17     ` Trond Myklebust
     [not found] <1QqNJ-4QH-37@gated-at.bofh.it>
     [not found] ` <1QqNJ-4QH-39@gated-at.bofh.it>
     [not found]   ` <1QqNJ-4QH-35@gated-at.bofh.it>
     [not found]     ` <1Qrhg-5hH-29@gated-at.bofh.it>
2004-04-30 20:17       ` Pascal Schmidt
2004-04-30 20:39         ` Trond Myklebust
2004-05-01 10:54           ` Pascal Schmidt
2004-05-04  9:55           ` Colin Paton
2004-05-04 13:52             ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1083260353.3686.63.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=colin.paton@etvinteractive.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®