From: Andreas Gruenbacher <agruen@suse.de>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Olaf Kirch <okir@suse.de>
Subject: [PATCH] Invalid notify_change(symlink, [ATTR_MODE]) in nfsd
Date: Tue, 04 May 2004 16:56:28 +0200 [thread overview]
Message-ID: <1083682588.1444.24.camel@winden.suse.de> (raw)
notify_change() gets called with at most the ATTR_MODE flag set for
symlinks, but it should be called with the ATTR_MODE flag cleared.
This triggers a bug in fs/reiserfs/xattr_acl.c (reiserfs plus acl
patches), and perhaps on other file systems, too. (On ext2/ext3 symlinks
have no ->setattr, there the bug does not trigger.)
int
reiserfs_acl_chmod (struct inode *inode)
{
struct posix_acl *acl, *clone;
int error;
==> if (S_ISLNK(inode->i_mode))
==> return -EOPNOTSUPP;
This is the fix -- please apply.
Index: linux-2.6.6-rc3/fs/nfsd/vfs.c
===================================================================
--- linux-2.6.6-rc3.orig/fs/nfsd/vfs.c
+++ linux-2.6.6-rc3/fs/nfsd/vfs.c
@@ -1212,7 +1212,7 @@ nfsd_symlink(struct svc_rqst *rqstp, str
if (EX_ISSYNC(fhp->fh_export))
nfsd_sync_dir(dentry);
if (iap) {
- iap->ia_valid &= ATTR_MODE /* ~(ATTR_MODE|ATTR_UID|ATTR_GID)*/;
+ iap->ia_valid &= ~ATTR_MODE;
if (iap->ia_valid) {
iap->ia_valid |= ATTR_CTIME;
iap->ia_mode = (iap->ia_mode&S_IALLUGO)
Cheers,
--
Andreas Gruenbacher <agruen@suse.de>
SUSE Labs, SUSE LINUX AG
reply other threads:[~2004-05-04 15:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1083682588.1444.24.camel@winden.suse.de \
--to=agruen@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okir@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®