From: Martin Josefsson <gandalf@wlug.westbo.se>
To: "David S. Miller" <davem@redhat.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, ultralinux@vger.kernel.org
Subject: Re: [PATCH 3/4] Consolidate sys32_select
Date: Wed, 26 May 2004 00:29:13 +0200 [thread overview]
Message-ID: <1085524153.969.104.camel@tux.rsn.bth.se> (raw)
In-Reply-To: <20040525151202.58010d51.davem@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
On Wed, 2004-05-26 at 00:12, David S. Miller wrote:
> Just fix the code to use compat_ptr(). That's what we created
> that macro for :-)
You mean in compat_sys_select() ?
compat_ptr() takes an u32 as argument, needs casting, ugly.
But you want it done that way?
I see this problem when compat_sys_select() is called directly from
syscall, not via sunos_select() which uses compat_ptr()
--
/Martin
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-05-25 22:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 16:00 consolidate compat readv/writev/execve/select/nfsservctl [v2] Arnd Bergmann
2004-04-16 16:02 ` [PATCH 1/4] Consolidate sys32_readv and sys32_writev Arnd Bergmann
2004-04-16 16:04 ` [PATCH 2/4] Consolidate do_execve32 Arnd Bergmann
2004-04-16 16:05 ` [PATCH 3/4] Consolidate sys32_select Arnd Bergmann
2004-05-25 22:02 ` Martin Josefsson
2004-05-25 22:12 ` David S. Miller
2004-05-25 22:29 ` Martin Josefsson [this message]
2004-04-16 16:08 ` [PATCH 4/4] Consolidate sys32_nfsservctl Arnd Bergmann
2004-05-25 23:10 [PATCH 3/4] Consolidate sys32 select Arnd Bergmann
2004-05-26 6:09 ` Martin Josefsson
2004-05-27 13:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085524153.969.104.camel@tux.rsn.bth.se \
--to=gandalf@wlug.westbo.se \
--cc=arnd@arndb.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ultralinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®