From: FabF <fabian.frederick@skynet.be>
To: Andrew Morton <akpm@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [2.6.7-rc1-mm1] lp int copy_to_user replaced
Date: Thu, 27 May 2004 19:32:08 +0200 [thread overview]
Message-ID: <1085679127.2070.21.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 119 bytes --]
Andrew,
Here's a patch to have standard __put_user for integer transfers in lp
driver.Is it correct ?
Regards,
FabF
[-- Attachment #2: lp1.diff --]
[-- Type: text/x-patch, Size: 1250 bytes --]
diff -Naur orig/drivers/char/lp.c edited/drivers/char/lp.c
--- orig/drivers/char/lp.c 2004-05-10 04:31:58.000000000 +0200
+++ edited/drivers/char/lp.c 2004-05-27 19:28:12.581860488 +0200
@@ -31,6 +31,8 @@
* Obsoleted and removed all the lowlevel stuff implemented in the last
* month to use the IEEE1284 functions (that handle the _new_ compatibilty
* mode fine).
+ *
+ * 27-MAY-2004 Replace int copy_to_user with put_user (Fabian Frederick)
*/
/* This driver should, in theory, work with any parallel port that has an
@@ -603,16 +605,14 @@
return -EINVAL;
break;
case LPGETIRQ:
- if (copy_to_user((int *) arg, &LP_IRQ(minor),
- sizeof(int)))
+ if (__put_user(LP_IRQ(minor), (int *) arg))
return -EFAULT;
break;
case LPGETSTATUS:
lp_claim_parport_or_block (&lp_table[minor]);
status = r_str(minor);
lp_release_parport (&lp_table[minor]);
-
- if (copy_to_user((int *) arg, &status, sizeof(int)))
+ if (__put_user(status, (int *) arg))
return -EFAULT;
break;
case LPRESET:
@@ -630,7 +630,7 @@
#endif
case LPGETFLAGS:
status = LP_F(minor);
- if (copy_to_user((int *) arg, &status, sizeof(int)))
+ if (__put_user(status, (int *) arg))
return -EFAULT;
break;
next reply other threads:[~2004-05-27 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-27 17:32 FabF [this message]
2004-05-27 17:39 ` Arjan van de Ven
2004-05-27 17:45 ` FabF
2004-05-27 17:43 ` Chris Wright
2004-05-27 18:01 ` viro
2004-05-27 18:06 ` FabF
2004-05-27 18:13 ` viro
2004-05-27 19:01 ` Andrew Morton
2004-05-27 18:15 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085679127.2070.21.camel@localhost.localdomain \
--to=fabian.frederick@skynet.be \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®