From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fix typo in pmac_zilog
Date: Fri, 28 May 2004 13:40:55 +1000 [thread overview]
Message-ID: <1085715655.6320.138.camel@gaston> (raw)
Hi !
This patch fixes a typo preventing channel B from working on the Rx
path of pmac zilog (never calling tty_flip_*). I think I never tested
channel B :)
Please, apply. Thanks to Hollis Blanchard for spotting the bug.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
--- 1.10/drivers/serial/pmac_zilog.c 2004-05-07 21:06:49 +10:00
+++ edited/drivers/serial/pmac_zilog.c 2004-05-28 13:38:07 +10:00
@@ -483,7 +483,7 @@
if (r3 & CHBEXT)
pmz_status_handle(uap_b, regs);
if (r3 & CHBRxIP)
- pmz_receive_chars(uap_b, regs);
+ tty = pmz_receive_chars(uap_b, regs);
if (r3 & CHBTxIP)
pmz_transmit_chars(uap_b);
rc = IRQ_HANDLED;
next reply other threads:[~2004-05-28 3:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-28 3:40 Benjamin Herrenschmidt [this message]
2004-05-30 6:42 ` David S. Miller
2004-05-30 7:13 ` Benjamin Herrenschmidt
2004-05-31 0:32 ` David S. Miller
2004-05-31 0:30 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085715655.6320.138.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®