From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbbKIUwL (ORCPT ); Mon, 9 Nov 2015 15:52:11 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:55192 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbbKIUwI (ORCPT ); Mon, 9 Nov 2015 15:52:08 -0500 From: Arnd Bergmann To: "Andrew F. Davis" Cc: Sebastian Reichel , linux-pm@vger.kernel.org, Pali Rohar , Xiong Zhou , linux-i2c@vger.kernel.org, Dmitry Eremin-Solenikov , David Woodhouse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] power: bq27xxx_battery: Revert "Remove unneeded dependency in Kconfig" Date: Mon, 09 Nov 2015 21:51:12 +0100 Message-ID: <10870776.N30IekZOBt@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5640D02D.6040601@ti.com> References: <3819790.E2ziFviWmU@wuerfel> <5640D02D.6040601@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:6BohFwVI37iiUUJrtM1ZbghrScIaYpPGoUyd2fkph/pIq36XWXK zWJjcqWmimuy7P2mFasKYK2sdKbWIEysApChMgM+EU7l3bdPdyYpkoQdWEKPf/ueh+XkJMy EAKvJxSOIrhokYbKf6o8CiVwdUlBvvNPc1TJZoQH/Ztl6ls+yPE7126FBU3TN0XxmwNY3OQ yIXWRYxAUtHiRLNI228rA== X-UI-Out-Filterresults: notjunk:1;V01:K0:+B1D7QxDot8=:CTW/mex6jzCZpoRZrzokuJ HkT25zN9Bo8zsDDIsnoPiIXtCFd68++WJUvc46TgMltPgnd+AlUZ0cx9W/tEnRABKmVURQibY DUBMQCGnJeohNxXewSrd1ffksnZzrcmuG0kfYtPdnKb1CPuFdYpJegVDGxw3XH/5JJBSmHAsT 1vgxkKq9gxxj4+SNY3S+3O96jKsVgY59MRroWxZbRvYbOsv+drXRly00xx9M27InS2zo5lzAY Now0SSy1CALzMexzHk3846wDTVDR4lotEmi+G1ADSwqO4U+sBbanUzCW1d0wRJBso1LqF2qEN 56C00Oau/XxHVD0Nq5FZMCz1STzKjbqMpVc/50Nzmr28oGUh64WaYL60QG7Gdtu6qHKE1VuGJ I2Bga7xYkPTjEOK3Bh0oVen4b4Um1zC/AjiWQ9YqBCHxRNguW0Bb4A4uf4Pdc6OdCZ6uMmLgF vILzvNisf+cZr9LzecTX+nAQZiY4zOwZPB+AhVODw+b7sxTcsLxjVzvW0ndXXmF21PNnOXn2P 8SWNXJcpq0vQy9qIanjiUYs+vahj16y7rVx0cdbWBtl3pfBnljyVEDUpsjix1/KQJQpDQ9JtD kyUm+baYcAZJHrgzXqWqYFXRh52RvkKv+yHhor8gpWLlmkw/uwl7nQA47/GGU3mzEqWW+uPk1 st5IEb/4Vwo18kXU+iwz/Sv/+5jhC1ItAaWT8NYQWgzXP/1vHn838Np9Re7dge1/wI1AoWzaD HsBpzwtNx8TvQkYO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 09 November 2015 10:56:13 Andrew F. Davis wrote: > On 11/09/2015 07:50 AM, Arnd Bergmann wrote: > Nothing enabled by BATTERY_BQ27XXX depends on I2C, this workaround is not > correct as it prevents BATTERY_BQ27XXX from being built-in when I2C is a > module, there is no reason for this limitation. > > The undefined references are caused by BATTERY_BQ27XXX being built-in AND > its I2C functionality being enabled (BATTERY_BQ27XXX_I2C) while I2C is a > module. Reorganizing this driver is being discussed anyway, but in the > meantime a more correct fix would be along the lines of: > > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig > index 6de6ec2..d1d32f9 100644 > --- a/drivers/power/Kconfig > +++ b/drivers/power/Kconfig > @@ -167,6 +167,7 @@ config BATTERY_BQ27XXX_I2C > bool "BQ27xxx I2C support" > depends on BATTERY_BQ27XXX > depends on I2C > + depends on !(I2C=m && BATTERY_BQ27XXX=y) > default y > help > Say Y here to enable support for batteries with BQ27xxx (I2C) chips. That works too, there is just very little difference in the end here, and it's easier to revert an patch that only introduces a regression than to do a different hack, especially if it's going to be reworked soon anyway. Do you want to submit the above as a fixup to your other patch or should we just do the revert? It would be good to get one of the two into -rc1. Arnd